From patchwork Thu Apr 17 19:32:50 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 340028 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1FB7E14008F for ; Fri, 18 Apr 2014 05:42:10 +1000 (EST) Received: from localhost ([::1]:34688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WasCF-00035t-OO for incoming@patchwork.ozlabs.org; Thu, 17 Apr 2014 15:42:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Was4g-0001Eu-RA for qemu-devel@nongnu.org; Thu, 17 Apr 2014 15:34:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Was4a-0002LR-Jp for qemu-devel@nongnu.org; Thu, 17 Apr 2014 15:34:18 -0400 Received: from mail-qg0-x22a.google.com ([2607:f8b0:400d:c04::22a]:52014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Was4a-0002Ke-GZ for qemu-devel@nongnu.org; Thu, 17 Apr 2014 15:34:12 -0400 Received: by mail-qg0-f42.google.com with SMTP id q107so894827qgd.1 for ; Thu, 17 Apr 2014 12:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=nDwnLqU1MLgcy/r4Ypjv6OyZLPjXFcNZdY9d9TQiCJs=; b=BZi6aVv/NffBKHAyCTktSMCDH5YVF7FikBzlsuut8n3F2I0gS0oDahWBL1q67NVGzG 9N9dgQaoULznNDieDwrCy8WYeTC9gnmd0undX3KcwvagqKyPHoh+hqRwavKczKRVZYrr 8DKO8rtZFgPC9/TaoMxyHrfHyZ7Lyn9NKW+YrmFzcVFQ/R5rKUs1X00Fa9l/h3UShTa3 UHb0WR7KlVuOccp3DkdUwRGdB76U2TEFsAtEexy9HrTOFa9DXv5sAeBc+t2ysmSG35Fn N9QW8KWtPpn5ci8+/xiRRSiOzkG9TUvIcbFTuGSyalLluxyq5VktZN1LjQzjkECrPIcX zEeA== X-Received: by 10.140.28.227 with SMTP id 90mr19789354qgz.11.1397763252098; Thu, 17 Apr 2014 12:34:12 -0700 (PDT) Received: from anchor.com (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPSA id b62sm2694452qge.2.2014.04.17.12.34.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Apr 2014 12:34:11 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 17 Apr 2014 12:32:50 -0700 Message-Id: <1397763195-1485-16-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1397763195-1485-1-git-send-email-rth@twiddle.net> References: <1397763195-1485-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c04::22a Subject: [Qemu-devel] [PATCH 15/40] target-alpha: Convert opcode 0x1F to source/sink X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Richard Henderson --- target-alpha/translate.c | 30 ++++++++++-------------------- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index 3c198eb..519ccf3 100644 --- a/target-alpha/translate.c +++ b/target-alpha/translate.c @@ -2992,40 +2992,33 @@ static ExitStatus translate_one(DisasContext *ctx, uint32_t insn) #else goto invalid_opc; #endif + case 0x1F: /* HW_ST (PALcode) */ #ifndef CONFIG_USER_ONLY REQUIRE_TB_FLAG(TB_FLAGS_PAL_MODE); { - TCGv addr, val; - addr = tcg_temp_new(); - if (rb != 31) { - tcg_gen_addi_i64(addr, cpu_ir[rb], disp12); - } else { - tcg_gen_movi_i64(addr, disp12); - } - if (ra != 31) { - val = cpu_ir[ra]; - } else { - val = tcg_temp_new(); - tcg_gen_movi_i64(val, 0); - } + TCGv addr = tcg_temp_new(); + va = load_gpr(ctx, ra); + vb = load_gpr(ctx, rb); + + tcg_gen_addi_i64(addr, vb, disp12); switch ((insn >> 12) & 0xF) { case 0x0: /* Longword physical access */ - gen_helper_stl_phys(cpu_env, addr, val); + gen_helper_stl_phys(cpu_env, addr, va); break; case 0x1: /* Quadword physical access */ - gen_helper_stq_phys(cpu_env, addr, val); + gen_helper_stq_phys(cpu_env, addr, va); break; case 0x2: /* Longword physical access with lock */ - gen_helper_stl_c_phys(val, cpu_env, addr, val); + gen_helper_stl_c_phys(dest_gpr(ctx, ra), cpu_env, addr, va); break; case 0x3: /* Quadword physical access with lock */ - gen_helper_stq_c_phys(val, cpu_env, addr, val); + gen_helper_stq_c_phys(dest_gpr(ctx, ra), cpu_env, addr, va); break; case 0x4: /* Longword virtual access */ @@ -3064,9 +3057,6 @@ static ExitStatus translate_one(DisasContext *ctx, uint32_t insn) /* Invalid */ goto invalid_opc; } - if (ra == 31) { - tcg_temp_free(val); - } tcg_temp_free(addr); break; }