From patchwork Wed Apr 16 11:29:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 339556 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 59DF6140080 for ; Wed, 16 Apr 2014 21:29:32 +1000 (EST) Received: from localhost ([::1]:54026 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaO1y-0007oU-9C for incoming@patchwork.ozlabs.org; Wed, 16 Apr 2014 07:29:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaO1d-0006t9-FR for qemu-devel@nongnu.org; Wed, 16 Apr 2014 07:29:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WaO1Z-000826-1d for qemu-devel@nongnu.org; Wed, 16 Apr 2014 07:29:09 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:53031 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaO1Y-000821-Sm for qemu-devel@nongnu.org; Wed, 16 Apr 2014 07:29:05 -0400 Received: from localhost ([127.0.0.1] helo=zen.linaro.local) by socrates.bennee.com with esmtp (Exim 4.80) (envelope-from ) id 1WaO2A-0007XL-JR; Wed, 16 Apr 2014 13:29:42 +0200 From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 16 Apr 2014 12:29:39 +0100 Message-Id: <1397647779-29287-1-git-send-email-alex.bennee@linaro.org> X-Mailer: git-send-email 1.9.2 In-Reply-To: <20140416080421.17349.87781.malonedeb@chaenomeles.canonical.com> References: <20140416080421.17349.87781.malonedeb@chaenomeles.canonical.com> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: alex.bennee@linaro.org X-SA-Exim-Scanned: No (on socrates.bennee.com); SAEximRunCond expanded to false X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 88.198.71.155 Cc: peter.maydell@linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [Qemu-devel] [PATCH] target-arm: A64: fix unallocated test of scalar SQXTUN X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The test for the U bit was incorrectly inverted in the scalar case of SQXTUN. This doesn't affect the vector case as the U bit is used to select XTN(2). Reported-by: Hao Liu Signed-off-by: Alex Bennée Reviewed-by: Claudio Fontana Reviewed-by: Peter Maydell --- target-arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index a74128c..0adffbb 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -7553,7 +7553,7 @@ static void disas_simd_scalar_two_reg_misc(DisasContext *s, uint32_t insn) } break; case 0x12: /* SQXTUN */ - if (u) { + if (!u) { unallocated_encoding(s); return; }