From patchwork Mon Apr 7 21:15:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Musta X-Patchwork-Id: 337540 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B093B140090 for ; Tue, 8 Apr 2014 07:16:18 +1000 (EST) Received: from localhost ([::1]:36862 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXGts-0005Bg-H1 for incoming@patchwork.ozlabs.org; Mon, 07 Apr 2014 17:16:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXGt9-0004zT-K1 for qemu-devel@nongnu.org; Mon, 07 Apr 2014 17:15:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXGt0-0004zH-8k for qemu-devel@nongnu.org; Mon, 07 Apr 2014 17:15:31 -0400 Received: from mail-qg0-x235.google.com ([2607:f8b0:400d:c04::235]:62123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXGt0-0004z9-4F; Mon, 07 Apr 2014 17:15:22 -0400 Received: by mail-qg0-f53.google.com with SMTP id z60so16330qgd.40 for ; Mon, 07 Apr 2014 14:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rSO055YDDHpV0Jii9XKxancV1Ejhn1hNKOTS85dn80c=; b=kCgvp9tN4nFOWLTlIHfd4AiHYYxZST8igURSaeMaYQvfAl0LP3CP/rqRg3Ysp0duWi htWLO13DtKKXvIT1blngLb5zscivtetwycTRtkbcrjJQqEGFhd4MbkCYQXNIbTsYs2iQ MobhjW9bLtY1edbWwrk2dA0vPz4oheK4geiAyijHBynjJ+6Y0Gaen3LNBnPqfPVUmPkx +P3ug8uXWnNlH/K53RFRRmPg8tlSnVDxay8qs6ypwfpNJh/uigCa16lriyzVT1jlihn4 pwviGkgvyje/1+8JYszo2EHXzlUEguGjIhYH0sQgzl2zlwHVZ9NbKCxwxLT2Bkz0utaB OteA== X-Received: by 10.224.37.10 with SMTP id v10mr5527897qad.104.1396905321754; Mon, 07 Apr 2014 14:15:21 -0700 (PDT) Received: from tmusta-sc.rchland.ibm.com (rchp4.rochester.ibm.com. [129.42.161.36]) by mx.google.com with ESMTPSA id p2sm36439145qah.38.2014.04.07.14.15.20 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 07 Apr 2014 14:15:21 -0700 (PDT) From: Tom Musta To: qemu-devel@nongnu.org Date: Mon, 7 Apr 2014 16:15:09 -0500 Message-Id: <1396905309-7208-3-git-send-email-tommusta@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1396905309-7208-1-git-send-email-tommusta@gmail.com> References: <1396905309-7208-1-git-send-email-tommusta@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c04::235 Cc: Tom Musta , qemu-ppc@nongnu.org Subject: [Qemu-devel] [V2 PATCH 2/2] target-ppc: Fix target_disas X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Inspect only bit 16 for the Little Endian test. Correct comment preceding the target_disas() function. Signed-off-by: Tom Musta --- disas.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/disas.c b/disas.c index 1e09293..968366d 100644 --- a/disas.c +++ b/disas.c @@ -191,7 +191,8 @@ static int print_insn_od_target(bfd_vma pc, disassemble_info *info) values: i386 - 1 means 16 bit code, 2 means 64 bit code arm - bit 0 = thumb, bit 1 = reverse endian, bit 2 = A64 - ppc - nonzero means little endian + ppc - bits 0:15 specify (optionally) the machine instruction set; + bit 16 indicates little endian. other targets - unused */ void target_disas(FILE *out, CPUArchState *env, target_ulong code, @@ -251,7 +252,7 @@ void target_disas(FILE *out, CPUArchState *env, target_ulong code, s.info.mach = bfd_mach_sparc_v9b; #endif #elif defined(TARGET_PPC) - if (flags >> 16) { + if ((flags >> 16) & 1) { s.info.endian = BFD_ENDIAN_LITTLE; } if (flags & 0xFFFF) {