From patchwork Thu Mar 27 09:09:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fam Zheng X-Patchwork-Id: 334255 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E9BAB14008D for ; Thu, 27 Mar 2014 20:15:15 +1100 (EST) Received: from localhost ([::1]:52473 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT6P3-0000il-Rf for incoming@patchwork.ozlabs.org; Thu, 27 Mar 2014 05:15:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT6LF-0004a3-6T for qemu-devel@nongnu.org; Thu, 27 Mar 2014 05:11:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WT6L9-0001tZ-0B for qemu-devel@nongnu.org; Thu, 27 Mar 2014 05:11:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT6L8-0001tK-Nh for qemu-devel@nongnu.org; Thu, 27 Mar 2014 05:11:10 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2R9B7Uu013864 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 27 Mar 2014 05:11:08 -0400 Received: from T430.redhat.com (vpn1-112-144.nay.redhat.com [10.66.112.144]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2R99etM007975; Thu, 27 Mar 2014 05:11:03 -0400 From: Fam Zheng To: qemu-devel@nongnu.org Date: Thu, 27 Mar 2014 17:09:48 +0800 Message-Id: <1395911388-31027-10-git-send-email-famz@redhat.com> In-Reply-To: <1395911388-31027-1-git-send-email-famz@redhat.com> References: <1395911388-31027-1-git-send-email-famz@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Kevin Wolf , Paolo Bonzini , Benoit Canet , Stefan Hajnoczi Subject: [Qemu-devel] [PATCH v4 9/9] qapi: Add transaction support to dirty-bitmap-{add, disable} X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This adds dirty-bitmap-add and dirty-bitmap-disable to transactions. With this, user can stop a dirty bitmap, start backup of it, and start another dirty bitmap atomically, so that the dirty bitmap is tracked incrementally and we don't miss any write. Signed-off-by: Fam Zheng --- blockdev.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ qapi-schema.json | 4 +++- 2 files changed, 71 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 4120dee..38dabe6 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1411,6 +1411,64 @@ static void drive_backup_abort(BlkTransactionState *common) } } +static void dirty_bitmap_add_prepare(BlkTransactionState *common, Error **errp) +{ + DirtyBitmap *action; + Error *local_err = NULL; + + action = common->action->dirty_bitmap_add; + qmp_dirty_bitmap_add(action->device, action->name, false, 0, &local_err); + if (error_is_set(&local_err)) { + error_propagate(errp, local_err); + } +} + +static void dirty_bitmap_add_abort(BlkTransactionState *common) +{ + DirtyBitmap *action; + BdrvDirtyBitmap *bm; + BlockDriverState *bs; + + action = common->action->dirty_bitmap_add; + bs = bdrv_find(action->device); + if (bs) { + bm = bdrv_find_dirty_bitmap(bs, action->name); + if (bm) { + bdrv_release_dirty_bitmap(bs, bm); + } + } +} + +static void dirty_bitmap_disable_prepare(BlkTransactionState *common, + Error **errp) +{ + DirtyBitmap *action; + Error *local_err = NULL; + + action = common->action->dirty_bitmap_disable; + qmp_dirty_bitmap_disable(action->device, action->name, + false, 0, &local_err); + if (error_is_set(&local_err)) { + error_propagate(errp, local_err); + } +} + +static void dirty_bitmap_disable_abort(BlkTransactionState *common) +{ + DirtyBitmap *action; + BdrvDirtyBitmap *bitmap; + BlockDriverState *bs; + + action = common->action->dirty_bitmap_disable; + bs = bdrv_find(action->device); + if (bs) { + bitmap = bdrv_find_dirty_bitmap(bs, action->name); + if (bitmap) { + bdrv_enable_dirty_bitmap(bs, bitmap); + } + } +} + static void abort_prepare(BlkTransactionState *common, Error **errp) { error_setg(errp, "Transaction aborted using Abort action"); @@ -1443,6 +1501,16 @@ static const BdrvActionOps actions[] = { .prepare = internal_snapshot_prepare, .abort = internal_snapshot_abort, }, + [TRANSACTION_ACTION_KIND_DIRTY_BITMAP_ADD] = { + .instance_size = sizeof(BlkTransactionState), + .prepare = dirty_bitmap_add_prepare, + .abort = dirty_bitmap_add_abort, + }, + [TRANSACTION_ACTION_KIND_DIRTY_BITMAP_DISABLE] = { + .instance_size = sizeof(BlkTransactionState), + .prepare = dirty_bitmap_disable_prepare, + .abort = dirty_bitmap_disable_abort, + }, }; /* diff --git a/qapi-schema.json b/qapi-schema.json index d99041c..48f7c15 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1994,7 +1994,9 @@ 'blockdev-snapshot-sync': 'BlockdevSnapshot', 'drive-backup': 'DriveBackup', 'abort': 'Abort', - 'blockdev-snapshot-internal-sync': 'BlockdevSnapshotInternal' + 'blockdev-snapshot-internal-sync': 'BlockdevSnapshotInternal', + 'dirty-bitmap-add': 'DirtyBitmap', + 'dirty-bitmap-disable': 'DirtyBitmap' } } ##