| Message ID | 1395396763-26081-4-git-send-email-cyliu@suse.com |
|---|---|
| State | New |
| Headers | show |
On 03/21/2014 04:12 AM, Chunyan Liu wrote: > Change qapi interfaces to output the newly added def_value_str when querying > command line options. > > Reviewed-by: Eric Blake <eblake@redhat.com> > Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com> > Signed-off-by: Chunyan Liu <cyliu@suse.com> > --- > qapi-schema.json | 6 +++++- > qmp-commands.hx | 2 ++ > util/qemu-config.c | 4 ++++ > 3 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index b68cd44..cf9174e 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -4088,12 +4088,16 @@ > # > # @help: #optional human readable text string, not suitable for parsing. > # > +# @default: #optional string representation of the default used > +# if the option is omitted. (since 2.0) We've missed 2.0; this needs to be 2.1 now. However, I'm okay if you keep my Reviewed-by with just that change.
I'll update. All patch series could also be available from: https://github.com/chunyanliu/qemu/commits/QemuOpts >>> On 3/22/2014 at 07:27 AM, in message <532CCADC.40607@redhat.com>, Eric Blake <eblake@redhat.com> wrote: > On 03/21/2014 04:12 AM, Chunyan Liu wrote: > > Change qapi interfaces to output the newly added def_value_str when > querying > > command line options. > > > > Reviewed-by: Eric Blake <eblake@redhat.com> > > Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com> > > Signed-off-by: Chunyan Liu <cyliu@suse.com> > > --- > > qapi-schema.json | 6 +++++- > > qmp-commands.hx | 2 ++ > > util/qemu-config.c | 4 ++++ > > 3 files changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/qapi-schema.json b/qapi-schema.json > > index b68cd44..cf9174e 100644 > > --- a/qapi-schema.json > > +++ b/qapi-schema.json > > @@ -4088,12 +4088,16 @@ > > # > > # @help: #optional human readable text string, not suitable for parsing. > > # > > +# @default: #optional string representation of the default used > > +# if the option is omitted. (since 2.0) > > We've missed 2.0; this needs to be 2.1 now. > > However, I'm okay if you keep my Reviewed-by with just that change. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > >
diff --git a/qapi-schema.json b/qapi-schema.json index b68cd44..cf9174e 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -4088,12 +4088,16 @@ # # @help: #optional human readable text string, not suitable for parsing. # +# @default: #optional string representation of the default used +# if the option is omitted. (since 2.0) +# # Since 1.5 ## { 'type': 'CommandLineParameterInfo', 'data': { 'name': 'str', 'type': 'CommandLineParameterType', - '*help': 'str' } } + '*help': 'str', + '*default': 'str' } } ## # @CommandLineOptionInfo: diff --git a/qmp-commands.hx b/qmp-commands.hx index a22621f..178aadd 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -2895,6 +2895,8 @@ Each array entry contains the following: or 'size') - "help": human readable description of the parameter (json-string, optional) + - "default": default value string for the parameter + (json-string, optional) Example: diff --git a/util/qemu-config.c b/util/qemu-config.c index f610101..d608b2f 100644 --- a/util/qemu-config.c +++ b/util/qemu-config.c @@ -68,6 +68,10 @@ static CommandLineParameterInfoList *query_option_descs(const QemuOptDesc *desc) info->has_help = true; info->help = g_strdup(desc[i].help); } + if (desc[i].def_value_str) { + info->has_q_default = true; + info->q_default = g_strdup(desc[i].def_value_str); + } entry = g_malloc0(sizeof(*entry)); entry->value = info;