| Message ID | 1395396763-26081-12-git-send-email-cyliu@suse.com |
|---|---|
| State | New |
| Headers | show |
On Fri, Mar 21, 2014 at 06:12:22PM +0800, Chunyan Liu wrote: > Currently this function is not used anywhere. In later patches, it will > replace print_option_parameters. print_option_parameters uses printf, > to avoid print info changes after switching to QemuOpts, change > qemu_opts_print from fprintf stderr to printf to keep consistent. > > Signed-off-by: Chunyan Liu <cyliu@suse.com> > --- > util/qemu-option.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/util/qemu-option.c b/util/qemu-option.c > index e9802f3..a9c53cd 100644 > --- a/util/qemu-option.c > +++ b/util/qemu-option.c > @@ -1012,7 +1012,7 @@ void qemu_opts_print(QemuOpts *opts) > > if (desc[0].name == NULL) { > QTAILQ_FOREACH(opt, &opts->head, next) { > - fprintf(stderr, "%s=\"%s\" ", opt->name, opt->str); > + printf("%s=\"%s\" ", opt->name, opt->str); > } > return; > } > @@ -1025,12 +1025,12 @@ void qemu_opts_print(QemuOpts *opts) > continue; > } > if (desc->type == QEMU_OPT_STRING) { > - fprintf(stderr, "%s='%s' ", desc->name, value); > + printf("%s='%s' ", desc->name, value); > } else { > - fprintf(stderr, "%s=%s ", desc->name, value); > + printf("%s=%s ", desc->name, value); > } > } > - fprintf(stderr, "\n"); > + printf("\n"); This new line is breaking most of the io tests since it changes the expected output. Regards... -- Leandro Dorileo > } > > static int opts_do_parse(QemuOpts *opts, const char *params, > -- > 1.7.12.4 > >
diff --git a/util/qemu-option.c b/util/qemu-option.c index e9802f3..a9c53cd 100644 --- a/util/qemu-option.c +++ b/util/qemu-option.c @@ -1012,7 +1012,7 @@ void qemu_opts_print(QemuOpts *opts) if (desc[0].name == NULL) { QTAILQ_FOREACH(opt, &opts->head, next) { - fprintf(stderr, "%s=\"%s\" ", opt->name, opt->str); + printf("%s=\"%s\" ", opt->name, opt->str); } return; } @@ -1025,12 +1025,12 @@ void qemu_opts_print(QemuOpts *opts) continue; } if (desc->type == QEMU_OPT_STRING) { - fprintf(stderr, "%s='%s' ", desc->name, value); + printf("%s='%s' ", desc->name, value); } else { - fprintf(stderr, "%s=%s ", desc->name, value); + printf("%s=%s ", desc->name, value); } } - fprintf(stderr, "\n"); + printf("\n"); } static int opts_do_parse(QemuOpts *opts, const char *params,
Currently this function is not used anywhere. In later patches, it will replace print_option_parameters. print_option_parameters uses printf, to avoid print info changes after switching to QemuOpts, change qemu_opts_print from fprintf stderr to printf to keep consistent. Signed-off-by: Chunyan Liu <cyliu@suse.com> --- util/qemu-option.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)