From patchwork Thu Mar 20 21:25:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Beniamino Galvani X-Patchwork-Id: 332404 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5CFCC2C00A2 for ; Fri, 21 Mar 2014 08:57:55 +1100 (EST) Received: from localhost ([::1]:49541 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQkVk-0002pC-B7 for incoming@patchwork.ozlabs.org; Thu, 20 Mar 2014 17:28:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQkTd-0000Bz-A9 for qemu-devel@nongnu.org; Thu, 20 Mar 2014 17:26:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQkTX-0003vj-GB for qemu-devel@nongnu.org; Thu, 20 Mar 2014 17:26:13 -0400 Received: from mail-ee0-x22d.google.com ([2a00:1450:4013:c00::22d]:51862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQkTX-0003vV-AE for qemu-devel@nongnu.org; Thu, 20 Mar 2014 17:26:07 -0400 Received: by mail-ee0-f45.google.com with SMTP id d17so1146369eek.4 for ; Thu, 20 Mar 2014 14:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=M+sNBv+nKZ/qjKfhE5ifGxHjjs1gv62YV1e0LDPFXu0=; b=GA+324rnjnXo4vBfm0xZuKNIZP5ybZdjZAdLdKhSD51Uugv5Eq5CecVHQZBn8du1tC siEIn3ChQqcYjYUP6/DP8W1+F6aLRoYeJxqqt4/9yflsCLJUZg5K1y1HL5sr6eKrDVXy h3XxEw73+0ZHvU1+n7ISDK9Zx+aiC4fJc3rkLuaDizUqipZKb8DuYs7LvN4p7njkid8Q AjWT1ZyOZ8p3jpy0KdSmK1H+XneyPdU29OfJx/aBO8xwmY9zfU08jsaqq+gdOhGruMmm VyptpcjOelojvMPKri9YPVaxMNTZ567QKhR9xODW9Sss4XyiS2mgdgyZRuNIq+GVM7Xk 6AsA== X-Received: by 10.15.21.2 with SMTP id c2mr28831530eeu.78.1395350766548; Thu, 20 Mar 2014 14:26:06 -0700 (PDT) Received: from sark.local (host151-4-dynamic.21-79-r.retail.telecomitalia.it. [79.21.4.151]) by mx.google.com with ESMTPSA id n5sm6941518eex.14.2014.03.20.14.26.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Mar 2014 14:26:05 -0700 (PDT) From: Beniamino Galvani To: qemu-devel@nongnu.org Date: Thu, 20 Mar 2014 22:25:16 +0100 Message-Id: <1395350719-3778-5-git-send-email-b.galvani@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395350719-3778-1-git-send-email-b.galvani@gmail.com> References: <1395350719-3778-1-git-send-email-b.galvani@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::22d Cc: Beniamino Galvani , Peter Maydell , Peter Crosthwaite , Li Guang Subject: [Qemu-devel] [PATCH v4 4/7] allwinner-a10-pit: use level triggered interrupts X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Convert the interrupt generation logic to the use of level triggered interrupts. Signed-off-by: Beniamino Galvani Reviewed-by: Peter Crosthwaite --- hw/timer/allwinner-a10-pit.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/hw/timer/allwinner-a10-pit.c b/hw/timer/allwinner-a10-pit.c index 696b7d9..5aa78a9 100644 --- a/hw/timer/allwinner-a10-pit.c +++ b/hw/timer/allwinner-a10-pit.c @@ -19,6 +19,15 @@ #include "sysemu/sysemu.h" #include "hw/timer/allwinner-a10-pit.h" +static void a10_pit_update_irq(AwA10PITState *s) +{ + int i; + + for (i = 0; i < AW_A10_PIT_TIMER_NR; i++) { + qemu_set_irq(s->irq[i], !!(s->irq_status & s->irq_enable & (1 << i))); + } +} + static uint64_t a10_pit_read(void *opaque, hwaddr offset, unsigned size) { AwA10PITState *s = AW_A10_PIT(opaque); @@ -74,9 +83,11 @@ static void a10_pit_write(void *opaque, hwaddr offset, uint64_t value, switch (offset) { case AW_A10_PIT_TIMER_IRQ_EN: s->irq_enable = value; + a10_pit_update_irq(s); break; case AW_A10_PIT_TIMER_IRQ_ST: s->irq_status &= ~value; + a10_pit_update_irq(s); break; case AW_A10_PIT_TIMER_BASE ... AW_A10_PIT_TIMER_BASE_END: index = offset & 0xf0; @@ -178,6 +189,8 @@ static void a10_pit_reset(DeviceState *dev) s->irq_enable = 0; s->irq_status = 0; + a10_pit_update_irq(s); + for (i = 0; i < 6; i++) { s->control[i] = AW_A10_PIT_DEFAULT_CLOCK; s->interval[i] = 0; @@ -203,7 +216,7 @@ static void a10_pit_timer_cb(void *opaque) ptimer_stop(s->timer[i]); s->control[i] &= ~AW_A10_PIT_TIMER_EN; } - qemu_irq_pulse(s->irq[i]); + a10_pit_update_irq(s); } }