From patchwork Tue Mar 11 10:03:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 329021 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1DB1F2C0096 for ; Tue, 11 Mar 2014 21:03:54 +1100 (EST) Received: from localhost ([::1]:53180 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNJXJ-0002eM-9S for incoming@patchwork.ozlabs.org; Tue, 11 Mar 2014 06:03:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNJWw-0002e1-5Q for qemu-devel@nongnu.org; Tue, 11 Mar 2014 06:03:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNJWq-00027w-5c for qemu-devel@nongnu.org; Tue, 11 Mar 2014 06:03:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNJWp-00027X-TR for qemu-devel@nongnu.org; Tue, 11 Mar 2014 06:03:20 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2BA3FXZ001082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 11 Mar 2014 06:03:16 -0400 Received: from [10.36.5.133] (vpn1-5-133.ams2.redhat.com [10.36.5.133]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2BA3Cix003089; Tue, 11 Mar 2014 06:03:13 -0400 Message-ID: <1394532186.22422.24.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann To: "Gabriel L. Somlo" Date: Tue, 11 Mar 2014 11:03:06 +0100 In-Reply-To: <20140310165606.GH17184@ERROL.INI.CMU.EDU> References: <20140310165606.GH17184@ERROL.INI.CMU.EDU> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: armbru@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, alex.williamson@redhat.com, kevin@koconnor.net, lersek@redhat.com Subject: Re: [Qemu-devel] SMBIOS (Set of 10 patches) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Hi, > On Thu, Mar 06, 2014 at 10:03:32AM +0100, Gerd Hoffmann wrote: > > So, if we manage to get the patches into shape in time for qemu 2.0 your > > way to do that is fine. We are pretty close to the 2.0 freeze though, > > so maybe we should better plan for post-2.0 anyway, especially as you > > plan to add more tables. > > Hopefully it's not too late, and the patches are in good enough shape :) I don't feel like rushing it, and hard freeze is tomorrow ... Issue #1: There are checkpatch errors (scripts/checkpatch.pl). Issue #2: There is one build warning: /home/kraxel/projects/qemu/hw/i386/smbios.c: In function 'smbios_build_type_16_table': /home/kraxel/projects/qemu/hw/i386/smbios.c:520:5: warning: comparison is always true due to limited range of data type [-Wtype-limits] t->maximum_capacity = ram_size < 2ULL << 40 ? ram_size >> 10 : 0x80000000; ^ Issue #3: Running a diff on the dmidecode output with and without the patches yields this: I think we should not generate a type0 table unless -smbios type0=... is explicitly specified on the qemu command line. It is about the firmware, and we should leave it to the firmware to fill it by default. If you are running OVMF (EFI) instead of SeaBIOS you should see it in the dmidecode output. Handle 0x0300, DMI type 3, 20 bytes Chassis Information - Manufacturer: Bochs + Manufacturer: QEMU Type: Other Lock: Not Present - Version: Not Specified + Version: pc-i440fx-2.0 Serial Number: Not Specified Asset Tag: Not Specified Boot-up State: Safe That is ok I think. -Handle 0x0401, DMI type 4, 32 bytes +Handle 0x0400, DMI type 4, 35 bytes Processor Information - Socket Designation: CPU 1 + Socket Designation: CPU 0 Hmm? Type: Central Processor Family: Other - Manufacturer: Bochs + Manufacturer: QEMU ID: 63 06 00 00 FD FB 8B 07 - Version: Not Specified + Version: pc-i440fx-2.0 Voltage: Unknown External Clock: Unknown Ok. - Max Speed: 2000 MHz - Current Speed: 2000 MHz + Max Speed: Unknown + Current Speed: Unknown Where does 2000 MHz come from? Does SeaBIOS pull something out of thin air or does it try to measure the speed? -Handle 0x1100, DMI type 17, 21 bytes +Handle 0x1100, DMI type 17, 27 bytes Memory Device Array Handle: 0x1000 - Error Information Handle: 0x0003 + Error Information Handle: Not Provided Same question. cheers, Gerd --- dmidecode.master 2014-03-11 10:38:06.799233009 +0100 +++ dmidecode.smbios 2014-03-11 10:39:36.664377785 +0100 @@ -1,20 +1,20 @@ # dmidecode 2.12 SMBIOS 2.4 present. -10 structures occupying 304 bytes. -Table at 0x000F09D0. +10 structures occupying 351 bytes. +Table at 0x000F09A0. That comes from upgrading some of the tables to newer versions, ok. Handle 0x0000, DMI type 0, 24 bytes BIOS Information - Vendor: Bochs - Version: Bochs - Release Date: 01/01/2011 + Vendor: QEMU + Version: pc-i440fx-2.0 + Release Date: 01/01/2014 Address: 0xE8000 Runtime Size: 96 kB ROM Size: 64 kB Characteristics: BIOS characteristics not supported Targeted content distribution is supported - BIOS Revision: 1.0 + BIOS Revision: 0.0