From patchwork Wed Mar 5 00:38:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 326555 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6672C2C0212 for ; Wed, 5 Mar 2014 11:43:26 +1100 (EST) Received: from localhost ([::1]:49491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKzvg-0007yR-8T for incoming@patchwork.ozlabs.org; Tue, 04 Mar 2014 19:43:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKzsv-0004jM-Ow for qemu-devel@nongnu.org; Tue, 04 Mar 2014 19:40:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKzsp-0000gS-Vz for qemu-devel@nongnu.org; Tue, 04 Mar 2014 19:40:33 -0500 Received: from mail-oa0-x22c.google.com ([2607:f8b0:4003:c02::22c]:44437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKzsp-0000gN-RV for qemu-devel@nongnu.org; Tue, 04 Mar 2014 19:40:27 -0500 Received: by mail-oa0-f44.google.com with SMTP id n16so325634oag.17 for ; Tue, 04 Mar 2014 16:40:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=2rD7OVmAXDd48sBudUG2o7c/tR+RqVWP9QesKzN7cqM=; b=ir7pMiEOSlY2C/0gwBzeCgpZV2SMwX0EzW9AKJfddsX3YvpkCTepDEBXzvIk/dZWcI HZvrVP/3lykzz24PgYUziVYi0Hm4vNpmaTYs2yGhUm/NwD80ztAKBZECXCtRvlQXJ+UY GTvCUAMAZW6dOrYlrGlln7ya8WtrCbWJAXJdKJExVxh+m6pdL+pxMI2rJXQoVlB+3S+U atR+SJiatrdmaEQrOJt1fLMECmuDSyYB+k7ZNvSH+ZqQmnxCGsuHFr/vvugsNDvxfjlV ScUYFQA5GitjrutW5OwCxUyMAVDcTVyb4kBhPFh3IBGFG5JqF1ThsosBBFuwwWZXFkNO AlKw== X-Received: by 10.182.160.102 with SMTP id xj6mr2108762obb.19.1393980027283; Tue, 04 Mar 2014 16:40:27 -0800 (PST) Received: from t430.minyard.home (pool-173-57-152-84.dllstx.fios.verizon.net. [173.57.152.84]) by mx.google.com with ESMTPSA id o6sm4120709oel.4.2014.03.04.16.40.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Mar 2014 16:40:26 -0800 (PST) Received: from t430.minyard.home (t430.minyard.home [127.0.0.1]) by t430.minyard.home (8.14.7/8.14.7) with ESMTP id s250eFoC009951; Tue, 4 Mar 2014 18:40:25 -0600 Received: (from cminyard@localhost) by t430.minyard.home (8.14.7/8.14.7/Submit) id s250e5Ld009939; Tue, 4 Mar 2014 18:40:05 -0600 From: minyard@acm.org To: qemu-devel@nongnu.org Date: Tue, 4 Mar 2014 18:38:54 -0600 Message-Id: <1393979937-9082-5-git-send-email-minyard@acm.org> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1393979937-9082-1-git-send-email-minyard@acm.org> References: <1393979937-9082-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c02::22c Cc: bcketchum@gmail.com, Corey Minyard , hwd@huawei.com, afaerber@suse.de, mst@redhat.com Subject: [Qemu-devel] [PATCH 4/7] qemu-char: remove free of chr from win_stdio_close X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Corey Minyard This will result in a double free on close, because it's freed in qemu_chr_delete() right after calling the close function. Signed-off-by: Corey Minyard --- qemu-char.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 6d6dd36..4ac131d 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2105,7 +2105,6 @@ static void win_stdio_close(CharDriverState *chr) } g_free(chr->opaque); - g_free(chr); } static CharDriverState *qemu_chr_open_stdio(CharDriverState *chr,