Message ID | 1391492590-8844-1-git-send-email-sw@weilnetz.de |
---|---|
State | Accepted |
Headers | show |
On 02/04/14 06:43, Stefan Weil wrote: > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > scripts/switch-timer-api | 2 +- > tests/i440fx-test.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/switch-timer-api b/scripts/switch-timer-api > index a369a08..b0e230b 100755 > --- a/scripts/switch-timer-api > +++ b/scripts/switch-timer-api > @@ -20,7 +20,7 @@ sub Syntax > print STDERR <<STOP; > Usage: $FindBin::Script [options] FILE ... > > -Translate each FILE to the new Qemu timer API. If no files > +Translate each FILE to the new QEMU timer API. If no files > are passed, a reasonable guess is taken. > > Options: > diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c > index fa3e3d6..bcd2181 100644 > --- a/tests/i440fx-test.c > +++ b/tests/i440fx-test.c > @@ -350,7 +350,7 @@ static void test_i440fx_firmware(FirmwareTestFixture *fixture, > qtest_start(cmdline); > g_free(cmdline); > > - /* Qemu has loaded the firmware (because qtest_start() only returns after > + /* QEMU has loaded the firmware (because qtest_start() only returns after > * the QMP handshake completes). We must unlink the firmware blob right > * here, because any assertion firing below would leak it in the > * filesystem. This is also the reason why we recreate the blob every time > (I'm fine both ways.) Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Am 04.02.2014 06:43, schrieb Stefan Weil: > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > scripts/switch-timer-api | 2 +- > tests/i440fx-test.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Andreas Färber <afaerber@suse.de> but that is the same spelling found in every single mailing list message - any chance we can fix that too? (be it to all-lowercase or all-uppercase) Regards, Andreas
Am 04.02.2014 15:39, schrieb Andreas Färber: > Am 04.02.2014 06:43, schrieb Stefan Weil: >> Signed-off-by: Stefan Weil <sw@weilnetz.de> >> --- >> scripts/switch-timer-api | 2 +- >> tests/i440fx-test.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Andreas Färber <afaerber@suse.de> > > but that is the same spelling found in every single mailing list message > - any chance we can fix that too? (be it to all-lowercase or all-uppercase) > > Regards, > Andreas > Fixing the mailing list name would be good, but can only be done by Anthony AFAIK. See the previous discussion on this matter: http://lists.nongnu.org/archive/html/qemu-devel/2012-06/msg03648.html Regards, Stefan
Thanks, applied to trivial-patches queue. /mjt
diff --git a/scripts/switch-timer-api b/scripts/switch-timer-api index a369a08..b0e230b 100755 --- a/scripts/switch-timer-api +++ b/scripts/switch-timer-api @@ -20,7 +20,7 @@ sub Syntax print STDERR <<STOP; Usage: $FindBin::Script [options] FILE ... -Translate each FILE to the new Qemu timer API. If no files +Translate each FILE to the new QEMU timer API. If no files are passed, a reasonable guess is taken. Options: diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c index fa3e3d6..bcd2181 100644 --- a/tests/i440fx-test.c +++ b/tests/i440fx-test.c @@ -350,7 +350,7 @@ static void test_i440fx_firmware(FirmwareTestFixture *fixture, qtest_start(cmdline); g_free(cmdline); - /* Qemu has loaded the firmware (because qtest_start() only returns after + /* QEMU has loaded the firmware (because qtest_start() only returns after * the QMP handshake completes). We must unlink the firmware blob right * here, because any assertion firing below would leak it in the * filesystem. This is also the reason why we recreate the blob every time
Signed-off-by: Stefan Weil <sw@weilnetz.de> --- scripts/switch-timer-api | 2 +- tests/i440fx-test.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)