diff mbox

tests/.gitignore: Ignore tests/check-qom-interface

Message ID 1390811181-21772-1-git-send-email-famz@redhat.com
State New
Headers show

Commit Message

Fam Zheng Jan. 27, 2014, 8:26 a.m. UTC
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/.gitignore | 1 +
 1 file changed, 1 insertion(+)

Comments

Alex Bennée Jan. 27, 2014, 11:20 a.m. UTC | #1
famz@redhat.com writes:

> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/.gitignore | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/.gitignore b/tests/.gitignore
> index 1aed224..9ba9d96 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -4,6 +4,7 @@ check-qint
>  check-qjson
>  check-qlist
>  check-qstring
> +check-qom-interface
>  test-aio
>  test-bitops
>  test-throttle

Are these generated test files? I've been looking at the tcg-tests and
while architecture ones won't clash there are a bunch of generic linux
tests that should probably be built one per target architecture. Should
we just be building all test files in the per-target build directories
like we do with qemu itself?


Cheers,

--
Alex Bennée
QEMU/KVM Hacker for Linaro
Michael Tokarev Feb. 1, 2014, 9:57 a.m. UTC | #2
27.01.2014 15:20, Alex Bennée wrote:
> famz@redhat.com writes:
> 
>> Signed-off-by: Fam Zheng <famz@redhat.com>
>> ---
>>  tests/.gitignore | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/.gitignore b/tests/.gitignore
>> index 1aed224..9ba9d96 100644
>> --- a/tests/.gitignore
>> +++ b/tests/.gitignore
>> @@ -4,6 +4,7 @@ check-qint
>>  check-qjson
>>  check-qlist
>>  check-qstring
>> +check-qom-interface
>>  test-aio
>>  test-bitops
>>  test-throttle

I've applied this change for now to trivial-patches queue.

> Are these generated test files? I've been looking at the tcg-tests and
> while architecture ones won't clash there are a bunch of generic linux
> tests that should probably be built one per target architecture. Should
> we just be building all test files in the per-target build directories
> like we do with qemu itself?

Or allow running whole testsuite in a separate directory.
This makes sense, but it is a much larger change, so for
now let's pick smaller changes which lets to build stuff
cleanly.

Thanks,

/mjt
> 
> Cheers,
> 
> --
> Alex Bennée
> QEMU/KVM Hacker for Linaro
> 
>
diff mbox

Patch

diff --git a/tests/.gitignore b/tests/.gitignore
index 1aed224..9ba9d96 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -4,6 +4,7 @@  check-qint
 check-qjson
 check-qlist
 check-qstring
+check-qom-interface
 test-aio
 test-bitops
 test-throttle