From patchwork Fri Dec 20 15:46:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 304127 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 502042C00DB for ; Sat, 21 Dec 2013 02:51:59 +1100 (EST) Received: from localhost ([::1]:50250 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vu2Mm-00022Q-HO for incoming@patchwork.ozlabs.org; Fri, 20 Dec 2013 10:51:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vu2Ib-0004yi-FT for qemu-devel@nongnu.org; Fri, 20 Dec 2013 10:47:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vu2IV-0000sf-Gx for qemu-devel@nongnu.org; Fri, 20 Dec 2013 10:47:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vu2IV-0000rp-9l for qemu-devel@nongnu.org; Fri, 20 Dec 2013 10:47:31 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBKFlUoE012924 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 20 Dec 2013 10:47:30 -0500 Received: from localhost (ovpn-112-40.ams2.redhat.com [10.36.112.40]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBKFlSWD000854; Fri, 20 Dec 2013 10:47:29 -0500 From: Stefan Hajnoczi To: Date: Fri, 20 Dec 2013 16:46:51 +0100 Message-Id: <1387554416-5837-14-git-send-email-stefanha@redhat.com> In-Reply-To: <1387554416-5837-1-git-send-email-stefanha@redhat.com> References: <1387554416-5837-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Anthony Liguori Subject: [Qemu-devel] [PULL 13/18] mirror: Don't close target X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Fam Zheng Let reference count manage target and don't call bdrv_close here. Signed-off-by: Fam Zheng Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/mirror.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 6dc27ad..5b2c119 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -482,7 +482,6 @@ immediate_exit: } bdrv_swap(s->target, s->common.bs); } - bdrv_close(s->target); bdrv_unref(s->target); block_job_completed(&s->common, ret); }