| Message ID | 1386786781-20253-1-git-send-email-aurelien@aurel32.net |
|---|---|
| State | New |
| Headers | show |
On 12/11/2013 10:33 AM, Aurelien Jarno wrote: > The comments apply to 8-bit stores, not 8-bit loads. > > Cc: Richard Henderson <rth@twiddle.net> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> Ack on the actual code comment fix. The commit comment is wrong. ;-) r~
diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 7ac8e45..495b901 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target.c @@ -1486,7 +1486,7 @@ static void tcg_out_qemu_st_direct(TCGContext *s, TCGReg datalo, TCGReg datahi, switch (memop & MO_SIZE) { case MO_8: - /* In 32-bit mode, 8-byte stores can only happen from [abcd]x. + /* In 32-bit mode, 8-bit stores can only happen from [abcd]x. Use the scratch register if necessary. */ if (TCG_TARGET_REG_BITS == 32 && datalo >= 4) { tcg_out_mov(s, TCG_TYPE_I32, scratch, datalo);
The comments apply to 8-bit stores, not 8-bit loads. Cc: Richard Henderson <rth@twiddle.net> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> --- tcg/i386/tcg-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)