| Message ID | 1386675153-1147-1-git-send-email-imammedo@redhat.com |
|---|---|
| State | New |
| Headers | show |
Igor Mammedov <imammedo@redhat.com> writes: > fixes regression caused by commit > ac86048 trace: Remove trace.h from console.h (less dependencies) > which makes build fail with: > > hw/display/qxl-render.c: In function ‘qxl_blit’: > hw/display/qxl-render.c:34:5: error: implicit declaration of function ‘trace_qxl_render_blit’ [-Werror=implicit-function-declaration] > trace_qxl_render_blit(qxl->guest_primary.qxl_stride, > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > --- > hw/display/qxl-render.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c > index d34b0c4..84f1367 100644 > --- a/hw/display/qxl-render.c > +++ b/hw/display/qxl-render.c > @@ -20,6 +20,7 @@ > */ > > #include "qxl.h" > +#include "trace.h" > > static void qxl_blit(PCIQXLDevice *qxl, QXLRect *rect) > { Fix is pending already: https://lists.nongnu.org/archive/html/qemu-devel/2013-12/msg01314.html
I'll commit in a few hours Regards, Anthony Liguori On Dec 10, 2013 4:37 AM, "Markus Armbruster" <armbru@redhat.com> wrote: > Igor Mammedov <imammedo@redhat.com> writes: > > > fixes regression caused by commit > > ac86048 trace: Remove trace.h from console.h (less dependencies) > > which makes build fail with: > > > > hw/display/qxl-render.c: In function ‘qxl_blit’: > > hw/display/qxl-render.c:34:5: error: implicit declaration of function > ‘trace_qxl_render_blit’ [-Werror=implicit-function-declaration] > > trace_qxl_render_blit(qxl->guest_primary.qxl_stride, > > > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > > --- > > hw/display/qxl-render.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c > > index d34b0c4..84f1367 100644 > > --- a/hw/display/qxl-render.c > > +++ b/hw/display/qxl-render.c > > @@ -20,6 +20,7 @@ > > */ > > > > #include "qxl.h" > > +#include "trace.h" > > > > static void qxl_blit(PCIQXLDevice *qxl, QXLRect *rect) > > { > > Fix is pending already: > https://lists.nongnu.org/archive/html/qemu-devel/2013-12/msg01314.html > >
diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c index d34b0c4..84f1367 100644 --- a/hw/display/qxl-render.c +++ b/hw/display/qxl-render.c @@ -20,6 +20,7 @@ */ #include "qxl.h" +#include "trace.h" static void qxl_blit(PCIQXLDevice *qxl, QXLRect *rect) {
fixes regression caused by commit ac86048 trace: Remove trace.h from console.h (less dependencies) which makes build fail with: hw/display/qxl-render.c: In function ‘qxl_blit’: hw/display/qxl-render.c:34:5: error: implicit declaration of function ‘trace_qxl_render_blit’ [-Werror=implicit-function-declaration] trace_qxl_render_blit(qxl->guest_primary.qxl_stride, Signed-off-by: Igor Mammedov <imammedo@redhat.com> --- hw/display/qxl-render.c | 1 + 1 file changed, 1 insertion(+)