diff mbox

[v3] fix -boot strict regressed in commit 6ef4716

Message ID 1386589995-15534-1-git-send-email-akong@redhat.com
State New
Headers show

Commit Message

Amos Kong Dec. 9, 2013, 11:53 a.m. UTC
Commit 6ef4716 cleaned up parsing of -boot option argument, but
accidentally dropped parameter strict.  It should have been updated
exactly like parameter menu. Do that.

Signed-off-by: Amos Kong <akong@redhat.com>
---
v2: remove bios.bin change, I just used it for testing (mjt)
v3: merge two patches together, correct the commitlog (markus)
---
 vl.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Markus Armbruster Dec. 9, 2013, 12:10 p.m. UTC | #1
Amos Kong <akong@redhat.com> writes:

> Commit 6ef4716 cleaned up parsing of -boot option argument, but
> accidentally dropped parameter strict.  It should have been updated
> exactly like parameter menu. Do that.
>
> Signed-off-by: Amos Kong <akong@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Michael Tokarev Dec. 9, 2013, 12:16 p.m. UTC | #2
09.12.2013 15:53, Amos Kong wrote:
> Commit 6ef4716 cleaned up parsing of -boot option argument, but
> accidentally dropped parameter strict.  It should have been updated
> exactly like parameter menu. Do that.
> 
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> v2: remove bios.bin change, I just used it for testing (mjt)
> v3: merge two patches together, correct the commitlog (markus)

Picked the new version up on trivial-patches, thank you!

/mjt
diff mbox

Patch

diff --git a/vl.c b/vl.c
index b0399de..ae6d0c6 100644
--- a/vl.c
+++ b/vl.c
@@ -461,7 +461,7 @@  static QemuOptsList qemu_boot_opts = {
             .type = QEMU_OPT_STRING,
         }, {
             .name = "strict",
-            .type = QEMU_OPT_STRING,
+            .type = QEMU_OPT_BOOL,
         },
         { /*End of list */ }
     },
@@ -4074,6 +4074,7 @@  int main(int argc, char **argv, char **envp)
         }
 
         boot_menu = qemu_opt_get_bool(opts, "menu", boot_menu);
+        boot_strict = qemu_opt_get_bool(opts, "strict", false);
     }
 
     if (!kernel_cmdline) {