From patchwork Thu Dec 5 12:02:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wayne Xia X-Patchwork-Id: 297098 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D24832C0077 for ; Thu, 5 Dec 2013 23:03:56 +1100 (EST) Received: from localhost ([::1]:53060 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoXes-0005EJ-GF for incoming@patchwork.ozlabs.org; Thu, 05 Dec 2013 07:03:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoXce-0002L9-C4 for qemu-devel@nongnu.org; Thu, 05 Dec 2013 07:01:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoXcV-0005E3-FK for qemu-devel@nongnu.org; Thu, 05 Dec 2013 07:01:36 -0500 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:38389) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoXcU-0005Ck-RO for qemu-devel@nongnu.org; Thu, 05 Dec 2013 07:01:27 -0500 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Dec 2013 17:31:23 +0530 Received: from d28dlp01.in.ibm.com (9.184.220.126) by e28smtp03.in.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 5 Dec 2013 17:31:20 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 77F1EE0058 for ; Thu, 5 Dec 2013 17:33:33 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rB5C1D1O60293294 for ; Thu, 5 Dec 2013 17:31:13 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rB5C1HNN003495 for ; Thu, 5 Dec 2013 17:31:17 +0530 Received: from RH64wenchao ([9.181.129.59]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id rB5C19ic002561; Thu, 5 Dec 2013 17:31:16 +0530 From: Wenchao Xia To: qemu-devel@nongnu.org Date: Thu, 5 Dec 2013 20:02:51 +0800 Message-Id: <1386244972-528-6-git-send-email-xiawenc@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1386244972-528-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1386244972-528-1-git-send-email-xiawenc@linux.vnet.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13120512-3864-0000-0000-00000B633B93 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 122.248.162.3 Cc: kwolf@redhat.com, jcody@redhat.com, Wenchao Xia , stefanha@redhat.com, mreitz@redhat.com Subject: [Qemu-devel] [PATCH V7 5/6] blkdebug: add debug events for snapshot X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Some code in qcow2-snapshot.c directly accesses bs->file, so in those places errors can't be injected by other events. Since the code in qcow2-snapshot.c is similar to the other qcow2 internal code (in regards to e.g. the L1 table), add some debug events. Signed-off-by: Wenchao Xia Reviewed-by: Max Reitz --- block/blkdebug.c | 4 ++++ block/qcow2-snapshot.c | 3 +++ include/block/block.h | 4 ++++ 3 files changed, 11 insertions(+), 0 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 37cf028..891b549 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -186,6 +186,10 @@ static const char *event_names[BLKDBG_EVENT_MAX] = { [BLKDBG_FLUSH_TO_OS] = "flush_to_os", [BLKDBG_FLUSH_TO_DISK] = "flush_to_disk", + + [BLKDBG_SNAPSHOT_L1_UPDATE] = "snapshot_l1_update", + [BLKDBG_SNAPSHOT_LIST_UPDATE] = "snapshot_list_update", + [BLKDBG_SNAPSHOT_HEADER_UPDATE] = "snapshot_header_update", }; static int get_event_by_name(const char *name, BlkDebugEvent *event) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index 5f787bc..2548de7 100644 --- a/block/qcow2-snapshot.c +++ b/block/qcow2-snapshot.c @@ -207,6 +207,7 @@ static int qcow2_write_snapshots(BlockDriverState *bs, Error **errp) } + BLKDBG_EVENT(bs->file, BLKDBG_SNAPSHOT_LIST_UPDATE); /* Write all snapshots to the new list */ for(i = 0; i < s->nb_snapshots; i++) { sn = s->snapshots + i; @@ -292,6 +293,7 @@ static int qcow2_write_snapshots(BlockDriverState *bs, Error **errp) header_data.nb_snapshots = cpu_to_be32(s->nb_snapshots); header_data.snapshots_offset = cpu_to_be64(snapshots_offset); + BLKDBG_EVENT(bs->file, BLKDBG_SNAPSHOT_HEADER_UPDATE); ret = bdrv_pwrite_sync(bs->file, offsetof(QCowHeader, nb_snapshots), &header_data, sizeof(header_data)); if (ret < 0) { @@ -452,6 +454,7 @@ void qcow2_snapshot_create(BlockDriverState *bs, goto dealloc_cluster; } + BLKDBG_EVENT(bs->file, BLKDBG_SNAPSHOT_L1_UPDATE); ret = bdrv_pwrite(bs->file, sn->l1_table_offset, l1_table, s->l1_size * sizeof(uint64_t)); if (ret < 0) { diff --git a/include/block/block.h b/include/block/block.h index 36efaea..8901683 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -515,6 +515,10 @@ typedef enum { BLKDBG_FLUSH_TO_OS, BLKDBG_FLUSH_TO_DISK, + BLKDBG_SNAPSHOT_L1_UPDATE, + BLKDBG_SNAPSHOT_LIST_UPDATE, + BLKDBG_SNAPSHOT_HEADER_UPDATE, + BLKDBG_EVENT_MAX, } BlkDebugEvent;