From patchwork Tue Nov 26 08:56:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Lieven X-Patchwork-Id: 294264 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E47002C009F for ; Tue, 26 Nov 2013 19:59:16 +1100 (EST) Received: from localhost ([::1]:57254 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlEUE-0001ZE-H5 for incoming@patchwork.ozlabs.org; Tue, 26 Nov 2013 03:59:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlESI-00078l-K8 for qemu-devel@nongnu.org; Tue, 26 Nov 2013 03:57:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlESC-0008Mp-Tp for qemu-devel@nongnu.org; Tue, 26 Nov 2013 03:57:14 -0500 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:35771 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlESC-0008MF-K3 for qemu-devel@nongnu.org; Tue, 26 Nov 2013 03:57:08 -0500 Received: (qmail 14243 invoked by uid 89); 26 Nov 2013 08:57:07 -0000 Received: from [82.141.1.145] by client-16-kamp (envelope-from , uid 89) with qmail-scanner-2010/03/19-MF (clamdscan: 0.98/18162. hbedv: 8.2.12.150/7.11.115.128. spamassassin: 3.3.1. Clear:RC:1(82.141.1.145):SA:0(-1.2/4.0):. Processed in 1.144463 secs); 26 Nov 2013 08:57:07 -0000 Received: from ns.kamp-intra.net (HELO dns.kamp-intra.net) ([82.141.1.145]) by mx01.kamp.de with SMTP; 26 Nov 2013 08:57:06 -0000 X-GL_Whitelist: yes Received: from lieven-pc.kamp-intra.net (lieven-pc.kamp-intra.net [172.21.12.60]) by dns.kamp-intra.net (Postfix) with ESMTP id 8441B206B0; Tue, 26 Nov 2013 09:56:04 +0100 (CET) Received: by lieven-pc.kamp-intra.net (Postfix, from userid 1000) id 608DB5FD57; Tue, 26 Nov 2013 09:56:29 +0100 (CET) From: Peter Lieven To: qemu-devel@nongnu.org Date: Tue, 26 Nov 2013 09:56:23 +0100 Message-Id: <1385456183-24840-10-git-send-email-pl@kamp.de> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1385456183-24840-1-git-send-email-pl@kamp.de> References: <1385456183-24840-1-git-send-email-pl@kamp.de> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a02:248:0:51::16 Cc: kwolf@redhat.com, pbonzini@redhat.com, Peter Lieven , stefanha@redhat.com Subject: [Qemu-devel] [PATCHv2 1.8 9/9] qemu-img: increase min_sparse to 128 sectors (64kb) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Suggested-by: Paolo Bonzini Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini --- qemu-img.c | 4 ++-- qemu-img.texi | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index cc7540f..6f1179b 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -101,7 +101,7 @@ static void help(void) " '-p' show progress of command (only certain commands)\n" " '-pp' show progress of command in sectors (only convert command)\n" " '-q' use Quiet mode - do not print any output (except errors)\n" - " '-S' indicates the consecutive number of bytes (defaults to 4k) that must\n" + " '-S' indicates the consecutive number of bytes (defaults to 64k) that must\n" " contain only zeros for qemu-img to create a sparse image during\n" " conversion. If the number of bytes is 0, the source will not be scanned for\n" " unallocated or zero sectors, and the destination image will always be\n" @@ -1158,7 +1158,7 @@ static int img_convert(int argc, char **argv) QEMUOptionParameter *out_baseimg_param; char *options = NULL; const char *snapshot_name = NULL; - int min_sparse = 8; /* Need at least 4k of zeros for sparse detection */ + int min_sparse = 128; /* Need at least 64k of zeros for sparse detection */ bool quiet = false; Error *local_err = NULL; diff --git a/qemu-img.texi b/qemu-img.texi index cb4a3eb..c0e86ab 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -195,7 +195,7 @@ Image conversion is also useful to get smaller image when using a growable format such as @code{qcow} or @code{cow}: the empty sectors are detected and suppressed from the destination image. -@var{sparse_size} indicates the consecutive number of bytes (defaults to 4k) +@var{sparse_size} indicates the consecutive number of bytes (defaults to 64k) that must contain only zeros for qemu-img to create a sparse image during conversion. If @var{sparse_size} is 0, the source will not be scanned for unallocated or zero sectors, and the destination image will always be