From patchwork Thu Nov 21 16:49:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 293200 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B89D72C00A1 for ; Fri, 22 Nov 2013 04:11:16 +1100 (EST) Received: from localhost ([::1]:34176 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjXUA-0006q5-V5 for incoming@patchwork.ozlabs.org; Thu, 21 Nov 2013 11:52:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjXRz-00046m-Jq for qemu-devel@nongnu.org; Thu, 21 Nov 2013 11:50:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjXRu-0005kZ-JS for qemu-devel@nongnu.org; Thu, 21 Nov 2013 11:49:55 -0500 Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]:37730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjXRu-0005kT-CS; Thu, 21 Nov 2013 11:49:50 -0500 Received: by mail-ee0-f41.google.com with SMTP id t10so3589062eei.14 for ; Thu, 21 Nov 2013 08:49:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=MuQ7nleviUsmzQag4kOel14FwzIckqYSUfl8H/l+miM=; b=M+ECn/+N8nbLnSd6rSpBZnVi1rRN0sPfNUmlNuhR5Mk+69VKdjA/EVqOyymUURRHYd EvXdcMnq0xtrsFpovbELsv6SXQdD0eoSjYIJ9drP4mn4wAofViJ7ZvoVHNleS4Q4bm8V U3J0AdfqhQuCEVg0B00qJr2Q34JHkf7h01bu1I1KWFxYZDLk4SfXRm0UqX46TIl+rrkl 7agOJ2WK4nNLCJ6GIat+cgHi3zAq4Yx9QruruHEaeGxgT9I5D1oJH8s7nQGyAqJl1ypz zBWUoBJLNAJ1m8hu0RR7IGyNq+sU1ePIGraVTSgM8J/DWTjMX4cHqJPCpn0Z8hJqJfin TodQ== X-Received: by 10.15.34.5 with SMTP id d5mr10090603eev.20.1385052589409; Thu, 21 Nov 2013 08:49:49 -0800 (PST) Received: from playground.lan (net-37-117-137-113.cust.dsl.vodafone.it. [37.117.137.113]) by mx.google.com with ESMTPSA id a51sm71819436eeh.8.2013.11.21.08.49.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Nov 2013 08:49:48 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 21 Nov 2013 17:49:29 +0100 Message-Id: <1385052578-32352-3-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1385052578-32352-1-git-send-email-pbonzini@redhat.com> References: <1385052578-32352-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::229 Cc: Peter Maydell , qemu-stable@nongnu.org, aliguori@amazon.com Subject: [Qemu-devel] [PULL 02/11] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Peter Maydell Our rules.mak adds '-rR' to MAKEFLAGS to indicate that we will be explicitly specifying everything and not relying on any default variables or rules. However we were accidentally relying on the default ARFLAGS ("rv"). This went unnoticed because of a bug in GNU Make 3.82 and earlier which meant that adding -rR to MAKEFLAGS only affected submakes, not the currently running instance. Explicitly set ARFLAGS in config-host.mak, in the same way we handle CFLAGS and LDFLAGS; this will allow us to work with Make 4.0. Thanks to Paul Smith for analyzing this bug for us. Cc: qemu-stable@nongnu.org Reported-by: Ken Moffat Signed-off-by: Peter Maydell Signed-off-by: Paolo Bonzini --- configure | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 508f6a5..ad12688 100755 --- a/configure +++ b/configure @@ -325,6 +325,9 @@ query_pkg_config() { pkg_config=query_pkg_config sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}" +# If the user hasn't specified ARFLAGS, default to 'rv', just as make does. +ARFLAGS="${ARFLAGS-rv}" + # default flags for all hosts QEMU_CFLAGS="-fno-strict-aliasing $QEMU_CFLAGS" QEMU_CFLAGS="-Wall -Wundef -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS" @@ -3695,6 +3698,7 @@ echo "C compiler $cc" echo "Host C compiler $host_cc" echo "C++ compiler $cxx" echo "Objective-C compiler $objcc" +echo "ARFLAGS $ARFLAGS" echo "CFLAGS $CFLAGS" echo "QEMU_CFLAGS $QEMU_CFLAGS" echo "LDFLAGS $LDFLAGS" @@ -4276,6 +4280,7 @@ echo "HOST_CC=$host_cc" >> $config_host_mak echo "CXX=$cxx" >> $config_host_mak echo "OBJCC=$objcc" >> $config_host_mak echo "AR=$ar" >> $config_host_mak +echo "ARFLAGS=$ARFLAGS" >> $config_host_mak echo "AS=$as" >> $config_host_mak echo "CPP=$cpp" >> $config_host_mak echo "OBJCOPY=$objcopy" >> $config_host_mak