From patchwork Sun Nov 17 21:11:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 291879 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C73852C0086 for ; Mon, 18 Nov 2013 08:12:07 +1100 (EST) Received: from localhost ([::1]:40326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vi9dT-0003jO-F6 for incoming@patchwork.ozlabs.org; Sun, 17 Nov 2013 16:12:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vi9d1-0003S4-Cf for qemu-devel@nongnu.org; Sun, 17 Nov 2013 16:11:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vi9cu-00034A-HK for qemu-devel@nongnu.org; Sun, 17 Nov 2013 16:11:35 -0500 Received: from qemu.weilnetz.de ([2a03:4000:2:362::1]:56365 helo=v2201305906712890.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vi9cu-00033l-9Z; Sun, 17 Nov 2013 16:11:28 -0500 Received: by v2201305906712890.yourvserver.net (Postfix, from userid 1000) id ED9281802A3; Sun, 17 Nov 2013 22:11:24 +0100 (CET) From: Stefan Weil To: Date: Sun, 17 Nov 2013 22:11:23 +0100 Message-Id: <1384722683-17205-1-git-send-email-sw@weilnetz.de> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a03:4000:2:362::1 Cc: qemu-trivial@nongnu.org, Stefan Weil , qemu-devel Subject: [Qemu-devel] [PATCH] libcacard/cac: Remove unused statement (value stored is never read) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Warning from ccc-analyzer: libcacard/cac.c:192:13: warning: Value stored to 'ret' is never read ret = VCARD_DONE; ^ ~~~~~~~~~~ Here 'ret' is assigned a value inside of a switch statement and also after that switch statement. Signed-off-by: Stefan Weil --- This patch is not needed for 1.7 (although I think that it is safe). libcacard/cac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libcacard/cac.c b/libcacard/cac.c index 7a06b5a..74ef3e3 100644 --- a/libcacard/cac.c +++ b/libcacard/cac.c @@ -189,7 +189,6 @@ cac_applet_pki_process_apdu(VCard *card, VCardAPDU *apdu, pki_applet->sign_buffer = sign_buffer; pki_applet->sign_buffer_len = size; *response = vcard_make_response(VCARD7816_STATUS_SUCCESS); - ret = VCARD_DONE; break; case 0x00: /* we now have the whole buffer, do the operation, result will be