From patchwork Tue Nov 12 16:33:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 290703 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 945892C00AB for ; Wed, 13 Nov 2013 03:34:21 +1100 (EST) Received: from localhost ([::1]:43820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgGux-0004iR-0V for incoming@patchwork.ozlabs.org; Tue, 12 Nov 2013 11:34:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgGu8-0004hq-DM for qemu-devel@nongnu.org; Tue, 12 Nov 2013 11:33:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgGu2-0007IN-2V for qemu-devel@nongnu.org; Tue, 12 Nov 2013 11:33:28 -0500 Received: from mail-ob0-x231.google.com ([2607:f8b0:4003:c01::231]:51836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgGu1-0007Hr-Uf for qemu-devel@nongnu.org; Tue, 12 Nov 2013 11:33:22 -0500 Received: by mail-ob0-f177.google.com with SMTP id wp4so4096481obc.22 for ; Tue, 12 Nov 2013 08:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=oR0LrnGGX+qCuAkMmd7LaDwy4p3+7SPJTeOPT9B4s6k=; b=aVnNfP9yPAYgZpG2+P5KpkGRj/20SfyVL0F6CUgQ+8zj6o2CTs7P9TS5n94FY1Viqe KCzcShyxt/w7TNz1dzHIJ/4MnxwLgHi2CFd/pPF+TxRgUV4JpexC7Mdh72PnSOMWnueY 2np/gqP7HRvvuXRnZ1znNksexjGPZDehnavsrIXgi6lLGwnsf4EyXxjq4bMpeomBXeCj knedI6vKpWuTjZyCRs6KimxH+LJoi4dmsLdNFaN4ma3j68pgVBBkYN7yD1W4QETr3V/+ 3U1NPsdCBA5qjHgZ+VwNae7nvGuD+V0+IjT394rsKSus41y3k/WxEPbZoQ4seDcxWFqN 0zMw== X-Received: by 10.182.204.41 with SMTP id kv9mr7497246obc.78.1384274001366; Tue, 12 Nov 2013 08:33:21 -0800 (PST) Received: from t430.minyard.home (pool-173-57-152-84.dllstx.fios.verizon.net. [173.57.152.84]) by mx.google.com with ESMTPSA id f2sm37349139oes.3.2013.11.12.08.33.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Nov 2013 08:33:20 -0800 (PST) Received: from t430.minyard.home (t430.minyard.home [127.0.0.1]) by t430.minyard.home (8.14.7/8.14.7) with ESMTP id rACGXIcw016603; Tue, 12 Nov 2013 10:33:18 -0600 Received: (from cminyard@localhost) by t430.minyard.home (8.14.7/8.14.7/Submit) id rACGXI4Z016602; Tue, 12 Nov 2013 10:33:18 -0600 From: Corey Minyard To: qemu-devel@nongnu.org Date: Tue, 12 Nov 2013 10:33:02 -0600 Message-Id: <1384273995-16486-4-git-send-email-cminyard@mvista.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1384273995-16486-1-git-send-email-cminyard@mvista.com> References: <1384273995-16486-1-git-send-email-cminyard@mvista.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::231 Cc: Bret Ketchum , Corey Minyard , =?UTF-8?q?Andreas=20F=C3=A4rber?= , "Michael S. Tsirkin" Subject: [Qemu-devel] [PATCH 03/16] qemu-char: remove free of chr from win_stdio_close X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This will result in a double free on close, because it's freed in qemu_chr_delete() right after calling the close function. Signed-off-by: Corey Minyard --- qemu-char.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 23d7647..935066d 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2075,7 +2075,6 @@ static void win_stdio_close(CharDriverState *chr) } g_free(chr->opaque); - g_free(chr); } static CharDriverState *qemu_chr_open_stdio(CharDriverState *chr,