| Message ID | 1384089617-4084-1-git-send-email-sw@weilnetz.de |
|---|---|
| State | Accepted |
| Headers | show |
10.11.2013 17:20, Stefan Weil wrote: > This reduces the dependencies on trace.h. > Only two source files which need console.h also need trace.h. Thanks, applied both patches to the trivial patches queue, after actually verifying that the result is sane ;) /mjt
diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index a6a8cdc..aba292c 100644 --- a/hw/display/vmware_vga.c +++ b/hw/display/vmware_vga.c @@ -23,6 +23,7 @@ */ #include "hw/hw.h" #include "hw/loader.h" +#include "trace.h" #include "ui/console.h" #include "hw/pci/pci.h" diff --git a/include/ui/console.h b/include/ui/console.h index 98edf41..4156a87 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -6,7 +6,6 @@ #include "qapi/qmp/qdict.h" #include "qemu/notify.h" #include "monitor/monitor.h" -#include "trace.h" #include "qapi-types.h" #include "qapi/error.h" diff --git a/ui/console.c b/ui/console.c index aad4fc9..11d5e6a 100644 --- a/ui/console.c +++ b/ui/console.c @@ -27,6 +27,7 @@ #include "qemu/timer.h" #include "qmp-commands.h" #include "sysemu/char.h" +#include "trace.h" //#define DEBUG_CONSOLE #define DEFAULT_BACKSCROLL 512
This reduces the dependencies on trace.h. Only two source files which need console.h also need trace.h. Signed-off-by: Stefan Weil <sw@weilnetz.de> --- Without this patch, 449 .o files depend on trace.h and must be rebuild whenever the file trace-events is changed. The patch reduces this number to 382 for the default QEMU build. hw/display/vmware_vga.c | 1 + include/ui/console.h | 1 - ui/console.c | 1 + 3 files changed, 2 insertions(+), 1 deletion(-)