From patchwork Thu Oct 24 21:08:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Edgar E. Iglesias" X-Patchwork-Id: 286022 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 869022C009E for ; Fri, 25 Oct 2013 08:13:07 +1100 (EST) Received: from localhost ([::1]:56254 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZSDJ-0002kt-Au for incoming@patchwork.ozlabs.org; Thu, 24 Oct 2013 17:13:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZSCg-0002W9-Fb for qemu-devel@nongnu.org; Thu, 24 Oct 2013 17:12:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZSCX-0006PF-V4 for qemu-devel@nongnu.org; Thu, 24 Oct 2013 17:12:26 -0400 Received: from mail-la0-x232.google.com ([2a00:1450:4010:c03::232]:63618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZSCX-0006Oy-Na for qemu-devel@nongnu.org; Thu, 24 Oct 2013 17:12:17 -0400 Received: by mail-la0-f50.google.com with SMTP id ec20so2350247lab.23 for ; Thu, 24 Oct 2013 14:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=yvqUK2pQ0zKOiJl9MCYgOiS4rT3EpyAeHS4+JUpyfjQ=; b=NgWkOoLiWh8sgSAsRfWeyAw5OBegFH2Wln2riyaNBJ6l9n0c6HLZ66be4O7/dxt1Qo 9kFbPhmNh1Nr4ytRiZc1qFi0m+7uMHeWC+3O9RlAL1ibnMRLg2mWkcXveEgpKknM/cFJ dDqcDUBOMHHj+4w/TJolY/3PjrzUkgIK/E6sHRQPOYmvB1sQqepdNRUE3rsb/nQTePdF 5jGYf5ZUlRbUY12tJzTSh8MIm1p6sOUfIsgGH/S3eKr7eLIAow0q77k7BJGYxsIEiz09 zxGhtZIrAkFGAgcLQ1fIDEkrD+zHjGpCyjJ6NPxHRs9lHyQHUix+FMyNX1bmsmq0dwgc mclw== X-Received: by 10.152.115.242 with SMTP id jr18mr2969373lab.40.1382649136749; Thu, 24 Oct 2013 14:12:16 -0700 (PDT) Received: from localhost (h59ec325f.selukar.dyn.perspektivbredband.net. [89.236.50.95]) by mx.google.com with ESMTPSA id 8sm3219365laq.5.2013.10.24.14.12.10 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 24 Oct 2013 14:12:11 -0700 (PDT) From: edgar.iglesias@gmail.com To: qemu-devel@nongnu.org Date: Thu, 24 Oct 2013 23:08:51 +0200 Message-Id: <1382648937-14769-5-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1382648937-14769-1-git-send-email-edgar.iglesias@gmail.com> References: <1382648937-14769-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::232 Subject: [Qemu-devel] [PATCH 04/10] microblaze: Improve srl X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: "Edgar E. Iglesias" write_carry only looks at bit zero, no need to mask out the others. Meassured a 12% speed improvement in linux-user srl loops. Signed-off-by: Edgar E. Iglesias --- target-microblaze/translate.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c index 916db15..93aafac 100644 --- a/target-microblaze/translate.c +++ b/target-microblaze/translate.c @@ -780,13 +780,10 @@ static void dec_bit(DisasContext *dc) case 0x1: case 0x41: /* srl. */ - t0 = tcg_temp_new(); LOG_DIS("srl r%d r%d\n", dc->rd, dc->ra); - /* Update carry. */ - tcg_gen_andi_tl(t0, cpu_R[dc->ra], 1); - write_carry(dc, t0); - tcg_temp_free(t0); + /* Update carry. Note that write carry only looks at the LSB. */ + write_carry(dc, cpu_R[dc->ra]); if (dc->rd) { if (op == 0x41) tcg_gen_shri_tl(cpu_R[dc->rd], cpu_R[dc->ra], 1);