diff mbox

hmp: block-stream: fix typo

Message ID 1379682463-5496-1-git-send-email-anthony@codemonkey.ws
State New
Headers show

Commit Message

Anthony Liguori Sept. 20, 2013, 1:07 p.m. UTC 
Found this by enabling C++ errors.  The bool and enum arguments
are mistakenly flipped.

Signed-off-by: Anthony Liguori <anthony@codemonkey.ws>
---
 hmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Hajnoczi Sept. 23, 2013, 12:10 p.m. UTC | #1 
On Fri, Sep 20, 2013 at 08:07:43AM -0500, Anthony Liguori wrote:
> Found this by enabling C++ errors.  The bool and enum arguments
> are mistakenly flipped.
> 
> Signed-off-by: Anthony Liguori <anthony@codemonkey.ws>
> ---
>  hmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hmp.c b/hmp.c
> index 2a90295..5891507 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1163,7 +1163,7 @@ void hmp_block_stream(Monitor *mon, const QDict *qdict)
>  
>      qmp_block_stream(device, base != NULL, base,
>                       qdict_haskey(qdict, "speed"), speed,
> -                     BLOCKDEV_ON_ERROR_REPORT, true, &error);
> +                     true, BLOCKDEV_ON_ERROR_REPORT, &error);
>  
>      hmp_handle_error(mon, &error);
>  }
> -- 
> 1.8.0

Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
diff mbox

Patch

diff --git a/hmp.c b/hmp.c
index 2a90295..5891507 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1163,7 +1163,7 @@  void hmp_block_stream(Monitor *mon, const QDict *qdict)
 
     qmp_block_stream(device, base != NULL, base,
                      qdict_haskey(qdict, "speed"), speed,
-                     BLOCKDEV_ON_ERROR_REPORT, true, &error);
+                     true, BLOCKDEV_ON_ERROR_REPORT, &error);
 
     hmp_handle_error(mon, &error);
 }