From patchwork Fri Sep 6 06:50:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 273080 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4EC3C2C008A for ; Fri, 6 Sep 2013 16:53:45 +1000 (EST) Received: from localhost ([::1]:35377 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHpvL-0004H5-5b for incoming@patchwork.ozlabs.org; Fri, 06 Sep 2013 02:53:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHptG-00010u-47 for qemu-devel@nongnu.org; Fri, 06 Sep 2013 02:51:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHpt9-0005AW-GH for qemu-devel@nongnu.org; Fri, 06 Sep 2013 02:51:34 -0400 Received: from mail-qe0-x22d.google.com ([2607:f8b0:400d:c02::22d]:43994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHpt9-0005AD-C9 for qemu-devel@nongnu.org; Fri, 06 Sep 2013 02:51:27 -0400 Received: by mail-qe0-f45.google.com with SMTP id 6so1516498qea.32 for ; Thu, 05 Sep 2013 23:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=7qDrsL8Duah6WmRc0QszltmUsu7n0g+Io284fCpJIYE=; b=SpVlRUscwmJRI3N9Gn3dM9TAmzNdr9scQbrY++MLqFspX6clQxgb72Ez3PyUsM54nC FHJkd54j2EnovE3BZ9YX9TeRSBM61xXnLDr8hva5r1gNHUCyQzeDKwO9zTc30IDZYEKM zuezLe2G5ZcinumtQQvTlD07qlV6Qv09uTLFo1xb2cPGAQgp20CZPWJAsbhv8ITq01vq Rl8mD/bKlE00TfkiMaHi/zT/82JhpRaMrrOSst6g3IMwM/sSCQyNuoTKRm2qmbHKPAdx kJftPfbXiW1Xn8zp0E4dXfBxNau4lmi2IBYMJUSoZZOyALtG5DtaTFhhLuW6F6QSKchr gkXQ== X-Received: by 10.224.36.136 with SMTP id t8mr2199503qad.7.1378450286991; Thu, 05 Sep 2013 23:51:26 -0700 (PDT) Received: from pebble.com (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPSA id i10sm1688981qev.8.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 05 Sep 2013 23:51:26 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 5 Sep 2013 23:50:28 -0700 Message-Id: <1378450242-27080-7-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1378450242-27080-1-git-send-email-rth@twiddle.net> References: <1378450242-27080-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c02::22d Cc: aurelien@aurel32.net, Richard Henderson Subject: [Qemu-devel] [PATCH 06/19] tcg-ia64: Avoid unnecessary stop bit in tcg_out_alu X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org When performing an operation with two input registers, we'd leave the stop bit (and thus an extra cycle) that's only needed when one or the other input is a constant. Signed-off-by: Richard Henderson --- tcg/ia64/tcg-target.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index ad5a6b9..f0c5e0b 100644 --- a/tcg/ia64/tcg-target.c +++ b/tcg/ia64/tcg-target.c @@ -1042,31 +1042,26 @@ static inline void tcg_out_st(TCGContext *s, TCGType type, TCGReg arg, } } -static inline void tcg_out_alu(TCGContext *s, uint64_t opc_a1, TCGArg ret, - TCGArg arg1, int const_arg1, - TCGArg arg2, int const_arg2) +static void tcg_out_alu(TCGContext *s, uint64_t opc_a1, TCGReg ret, TCGArg arg1, + int const_arg1, TCGArg arg2, int const_arg2) { - uint64_t opc1, opc2; + uint64_t opc1 = 0, opc2 = 0; if (const_arg1 && arg1 != 0) { opc1 = tcg_opc_a5(TCG_REG_P0, OPC_ADDL_A5, TCG_REG_R2, arg1, TCG_REG_R0); arg1 = TCG_REG_R2; - } else { - opc1 = INSN_NOP_M; } if (const_arg2 && arg2 != 0) { opc2 = tcg_opc_a5(TCG_REG_P0, OPC_ADDL_A5, TCG_REG_R3, arg2, TCG_REG_R0); arg2 = TCG_REG_R3; - } else { - opc2 = INSN_NOP_I; } - tcg_out_bundle(s, mII, - opc1, - opc2, + tcg_out_bundle(s, (opc1 || opc2 ? mII : miI), + opc1 ? opc1 : INSN_NOP_M, + opc2 ? opc2 : INSN_NOP_I, tcg_opc_a1(TCG_REG_P0, opc_a1, ret, arg1, arg2)); }