| Message ID | 1378290385-7003-1-git-send-email-aik@ozlabs.ru |
|---|---|
| State | New |
| Headers | show |
On Wed, Sep 04, 2013 at 08:26:25PM +1000, Alexey Kardashevskiy wrote: > KVM request types are normally defined using hex constants but QEMU traces > print decimal values instead, which is not very convenient. > > This changes the request type format from %d to %x. > > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> > Reviewed-by: Andreas Färber <afaerber@suse.de> > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> > --- > Changes: > v2: > * added "0x" to format strings so the change won't come unnoticed > * fixed the commit message > --- > trace-events | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Thanks, applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan
Il 09/09/2013 14:07, Stefan Hajnoczi ha scritto: > On Wed, Sep 04, 2013 at 08:26:25PM +1000, Alexey Kardashevskiy wrote: >> KVM request types are normally defined using hex constants but QEMU traces >> print decimal values instead, which is not very convenient. >> >> This changes the request type format from %d to %x. >> >> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> >> Reviewed-by: Andreas Färber <afaerber@suse.de> >> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> >> --- >> Changes: >> v2: >> * added "0x" to format strings so the change won't come unnoticed >> * fixed the commit message >> --- >> trace-events | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > > Thanks, applied to my tracing tree: > https://github.com/stefanha/qemu/commits/tracing Applied also to uq/master, since I don't see it in github. Paolo
diff --git a/trace-events b/trace-events index 8285c5a..c68b0c7 100644 --- a/trace-events +++ b/trace-events @@ -1167,9 +1167,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev migrate_set_state(int new_state) "new state %d" # kvm-all.c -kvm_ioctl(int type, void *arg) "type %d, arg %p" -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p" -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p" +kvm_ioctl(int type, void *arg) "type 0x%x, arg %p" +kvm_vm_ioctl(int type, void *arg) "type 0x%x, arg %p" +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type 0x%x, arg %p" kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d" # memory.c