From patchwork Fri Aug 23 09:23:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Kardashevskiy X-Patchwork-Id: 269361 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9476F2C0087 for ; Fri, 23 Aug 2013 19:24:44 +1000 (EST) Received: from localhost ([::1]:35959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCnbm-0005xg-O1 for incoming@patchwork.ozlabs.org; Fri, 23 Aug 2013 05:24:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCnah-0004z3-Ed for qemu-devel@nongnu.org; Fri, 23 Aug 2013 05:23:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCnab-0006MZ-AK for qemu-devel@nongnu.org; Fri, 23 Aug 2013 05:23:35 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:40408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCnab-0006Ki-1H for qemu-devel@nongnu.org; Fri, 23 Aug 2013 05:23:29 -0400 Received: by mail-pa0-f45.google.com with SMTP id bg4so450402pad.32 for ; Fri, 23 Aug 2013 02:23:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=55RK7ryPgWdFsqSuUBBgta600UhSImHvx4CmN7MF10c=; b=nkH2nF3QgG0gCU9yL0OGgL5Jlb7f1GoyEYNhypE7aweukWs5itsQganTnlhw8ldtMI /Blf4vlOtzDDvzrWkBrPyRokW1V0dOB5RYSdko9bDOWX+DF7VE4sZTvq1uyfFmnjJtiy TGyB7rhrmKxOyAU1LsyFZ+rbUS53AQQVoCxf7wt5IxC6AXh2ymY5R6Oz3u/4CiA7uSWW uHEaAX6hJjZicI25kNWGDKEx39aRXMhV7czChhD4+DnkED1Q2M1mjGrcpvICtg/UOCPy cnb6vJvkHgjqjUb922zZCHAw6cEpbTVQlkN2kz3JLpsHtSwybhKqdLze5xGFNSahqRjn LgWg== X-Gm-Message-State: ALoCoQnwJRQxDm6TbmckXX+KTqtDgQFFOHQ/caiOjByB2WDQA06dsK9hUl+Ql8XcW5JWT71CsX5P X-Received: by 10.66.120.145 with SMTP id lc17mr998684pab.182.1377249808321; Fri, 23 Aug 2013 02:23:28 -0700 (PDT) Received: from ka1.ozlabs.ibm.com (ibmaus65.lnk.telstra.net. [165.228.126.9]) by mx.google.com with ESMTPSA id xe9sm22261544pab.0.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 23 Aug 2013 02:23:26 -0700 (PDT) From: Alexey Kardashevskiy To: qemu-devel@nongnu.org Date: Fri, 23 Aug 2013 19:23:17 +1000 Message-Id: <1377249797-12623-1-git-send-email-aik@ozlabs.ru> X-Mailer: git-send-email 1.8.4.rc4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.220.45 Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, Alexander Graf , Paolo Bonzini Subject: [Qemu-devel] [PATCH] spapr-vscsi: Report error on unsupported MAD requests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The existing driver just dropped unsupported requests. This adds error responses to those unhandled requests. Signed-off-by: Alexey Kardashevskiy --- hw/scsi/spapr_vscsi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c index cc35b1b..9259d7e 100644 --- a/hw/scsi/spapr_vscsi.c +++ b/hw/scsi/spapr_vscsi.c @@ -957,24 +957,24 @@ static int vscsi_handle_mad_req(VSCSIState *s, vscsi_req *req) break; case VIOSRP_ERROR_LOG_TYPE: fprintf(stderr, "Unsupported ERROR LOG MAD IU\n"); - mad->error_log.common.status = cpu_to_be16(1); - vscsi_send_iu(s, req, sizeof(mad->error_log), VIOSRP_MAD_FORMAT); break; case VIOSRP_ADAPTER_INFO_TYPE: vscsi_send_adapter_info(s, req); - break; + return 1; case VIOSRP_HOST_CONFIG_TYPE: - mad->host_config.common.status = cpu_to_be16(1); - vscsi_send_iu(s, req, sizeof(mad->host_config), VIOSRP_MAD_FORMAT); + fprintf(stderr, "Unsupported HOST CONFIG TYPE MAD IU\n"); break; case VIOSRP_CAPABILITIES_TYPE: vscsi_send_capabilities(s, req); - break; + return 1; default: fprintf(stderr, "VSCSI: Unknown MAD type %02x\n", be32_to_cpu(mad->empty_iu.common.type)); } + mad->empty_iu.common.status = cpu_to_be16(VIOSRP_MAD_NOT_SUPPORTED); + vscsi_send_iu(s, req, mad->empty_iu.common.length, VIOSRP_MAD_FORMAT); + return 1; }