From patchwork Wed Aug 21 02:06:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia Liu X-Patchwork-Id: 268664 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CB9CC2C00A6 for ; Wed, 21 Aug 2013 12:07:57 +1000 (EST) Received: from localhost ([::1]:51042 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBxpz-0003VL-Lr for incoming@patchwork.ozlabs.org; Tue, 20 Aug 2013 22:07:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBxpX-0003Ok-Q8 for qemu-devel@nongnu.org; Tue, 20 Aug 2013 22:07:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBxpS-0007vS-BA for qemu-devel@nongnu.org; Tue, 20 Aug 2013 22:07:27 -0400 Received: from mail-pd0-x235.google.com ([2607:f8b0:400e:c02::235]:64644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBxpS-0007vI-4a for qemu-devel@nongnu.org; Tue, 20 Aug 2013 22:07:22 -0400 Received: by mail-pd0-f181.google.com with SMTP id g10so1193394pdj.12 for ; Tue, 20 Aug 2013 19:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :content-type; bh=TX8gXLpk0FsjEUgJ501cSou63DJY9mZjeeXL5ez4dBg=; b=J5+5EY/56gYne9YB4KCHpP2VJz2uZuocdubZ/eByHhVAGSiPHR4O8NdojWN6WE0fkr eWqrynuHfuXBh6EPBbreXjEYpv6P+xIWkgu1Gx1OX55oEbj9MhADLdQuMZeIFl8WERDc DTMD9MtdE7Ckg2ad4Rb3MxBnKAM9vrt4h+he9d64LJJh7S0p5TxL+8IoOnkj4531CWq7 FuNUkWKNkCGBSoyC18DRF1kkG1ED1t3f2AjWc01PhWwlmvKaYSv0m0pLAIHSjAs7Rzwx dPu4OzbLzOW18gPvcGUDhd7mgmCqLZrVQuuikwGsRfEKcWiEJfMeoVzpKZk46Vml64pA NLyQ== X-Received: by 10.68.160.193 with SMTP id xm1mr5175895pbb.88.1377050841437; Tue, 20 Aug 2013 19:07:21 -0700 (PDT) Received: from localhost.localdomain ([114.247.222.194]) by mx.google.com with ESMTPSA id qv4sm5038367pbc.16.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 20 Aug 2013 19:07:20 -0700 (PDT) From: Jia Liu To: qemu-devel@nongnu.org Date: Wed, 21 Aug 2013 10:06:49 +0800 Message-Id: <1377050811-11116-2-git-send-email-proljc@gmail.com> X-Mailer: git-send-email 1.7.12.4 (Apple Git-37) In-Reply-To: <1377050811-11116-1-git-send-email-proljc@gmail.com> References: <1377050811-11116-1-git-send-email-proljc@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c02::235 Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, xi.wang@gmail.com Subject: [Qemu-devel] [PULL 1/3] hw/openrisc: Avoid using uninitialised variable 'entry' X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org clang warns that cpu_openrisc_load_kernel() can use 'entry' uninitialized: hw/openrisc/openrisc_sim.c:69:9: error: variable 'entry' is used uninitialized whenever '&&' condition is false [-Werror,-Wsometimes-uninitialized] if (kernel_filename && !qtest_enabled()) { ^~~~~~~~~~~~~~~ hw/openrisc/openrisc_sim.c:91:19: note: uninitialized use occurs here cpu->env.pc = entry; ^~~~~ Fix this by not attempting to change the CPU's starting PC unless we actually loaded a kernel. Signed-off-by: Peter Maydell Reviewed-by: Jia Liu --- hw/openrisc/openrisc_sim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index a08f27c..28fa41d 100644 --- a/hw/openrisc/openrisc_sim.c +++ b/hw/openrisc/openrisc_sim.c @@ -86,9 +86,8 @@ static void cpu_openrisc_load_kernel(ram_addr_t ram_size, kernel_filename); exit(1); } + cpu->env.pc = entry; } - - cpu->env.pc = entry; } static void openrisc_sim_init(QEMUMachineInitArgs *args)