From patchwork Tue Aug 13 15:10:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 266866 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (unknown [IPv6:2001:4830:134:3::12]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0CD172C0149 for ; Wed, 14 Aug 2013 01:42:03 +1000 (EST) Received: from localhost ([::1]:58223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9GIK-0006Y8-Ad for incoming@patchwork.ozlabs.org; Tue, 13 Aug 2013 11:14:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9GGE-0004PE-AA for qemu-devel@nongnu.org; Tue, 13 Aug 2013 11:11:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V9GG9-0003hA-F8 for qemu-devel@nongnu.org; Tue, 13 Aug 2013 11:11:50 -0400 Received: from mail-oa0-x236.google.com ([2607:f8b0:4003:c02::236]:56735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9GG9-0003h6-AE; Tue, 13 Aug 2013 11:11:45 -0400 Received: by mail-oa0-f54.google.com with SMTP id o6so11421023oag.41 for ; Tue, 13 Aug 2013 08:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=lx5CDhtRPlMbwaX11NcRZl9E/VZvOvM+JVpRN1/hxS0=; b=aHaLWHEjoEOg6j58NMKFyYbF0p0aDUwpaqrU7lqWvTNGmMG8mCJUWLGgW06HkmRSVS PAXiJEEUVulnt2L8RsANfkbVWGMqXRUAiJ7X2L8IsN87i7XP4Ymg5/EXRSpE3u14P72v D4PukCblVE/5jGwkeryzyU5xvATUlIU5YzRBSBGcoJlPfzG7UutrjnIuhIG5ASKycMl6 TwICCd72M4LWxQPJKRSP/gyeOwgRipH1Pa3QsODsKUxBcVeluKt01LMiDHtwRnxYp8Vp TMaT788HpPVBYj/1/o7qmwHUaNDoHzpLjGLMVCLF7CwdVpjQIelV7RE1RczdGf34sVGG k8HQ== X-Received: by 10.182.214.98 with SMTP id nz2mr4216206obc.37.1376406704754; Tue, 13 Aug 2013 08:11:44 -0700 (PDT) Received: from loki.austin.ibm.com ([32.97.110.51]) by mx.google.com with ESMTPSA id uz16sm12947878obc.5.2013.08.13.08.11.43 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 13 Aug 2013 08:11:44 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Tue, 13 Aug 2013 10:10:28 -0500 Message-Id: <1376406680-16302-5-git-send-email-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1376406680-16302-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1376406680-16302-1-git-send-email-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c02::236 Cc: aliguori@us.ibm.com, qemu-stable@nongnu.org Subject: [Qemu-devel] [PATCH 04/56] qxl: Fix QXLRam initialisation. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Anthony PERARD The qxl driver expect NULL for QXLRam.memory_configs, but this is never initialized. If memory is set to 0xc2c2.., it leads to a spice-critical error when trying to start qxl. Signed-off-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Signed-off-by: Michael Tokarev (cherry picked from commit 329f97fc4ff4b533fcd2d8f4eab6c9c2568aed27) Signed-off-by: Michael Roth --- hw/display/qxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index c475cb1..937a402 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -387,6 +387,7 @@ static void init_qxl_ram(PCIQXLDevice *d) d->ram->int_pending = cpu_to_le32(0); d->ram->int_mask = cpu_to_le32(0); d->ram->update_surface = 0; + d->ram->monitors_config = 0; SPICE_RING_INIT(&d->ram->cmd_ring); SPICE_RING_INIT(&d->ram->cursor_ring); SPICE_RING_INIT(&d->ram->release_ring);