Message ID | 1375265640-27307-2-git-send-email-famz@redhat.com |
---|---|
State | New |
Headers | show |
Reviewed-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com> > we need bdrv_new() to properly initialize BDS, don't allocate memory > manually. > > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > block/vvfat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/vvfat.c b/block/vvfat.c > index cd3b8ed..a827d91 100644 > --- a/block/vvfat.c > +++ b/block/vvfat.c > @@ -2943,7 +2943,7 @@ static int enable_write_target(BDRVVVFATState *s) > unlink(s->qcow_filename); > #endif > > - s->bs->backing_hd = calloc(sizeof(BlockDriverState), 1); > + s->bs->backing_hd = bdrv_new(""); > s->bs->backing_hd->drv = &vvfat_write_target; > s->bs->backing_hd->opaque = g_malloc(sizeof(void*)); > *(void**)s->bs->backing_hd->opaque = s; >
diff --git a/block/vvfat.c b/block/vvfat.c index cd3b8ed..a827d91 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -2943,7 +2943,7 @@ static int enable_write_target(BDRVVVFATState *s) unlink(s->qcow_filename); #endif - s->bs->backing_hd = calloc(sizeof(BlockDriverState), 1); + s->bs->backing_hd = bdrv_new(""); s->bs->backing_hd->drv = &vvfat_write_target; s->bs->backing_hd->opaque = g_malloc(sizeof(void*)); *(void**)s->bs->backing_hd->opaque = s;
we need bdrv_new() to properly initialize BDS, don't allocate memory manually. Signed-off-by: Fam Zheng <famz@redhat.com> --- block/vvfat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)