From patchwork Fri Jul 26 22:05:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 262330 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E772E2C00EE for ; Sat, 27 Jul 2013 08:06:51 +1000 (EST) Received: from localhost ([::1]:36927 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2q9x-0008LW-KN for incoming@patchwork.ozlabs.org; Fri, 26 Jul 2013 18:06:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2q9G-000895-V0 for qemu-devel@nongnu.org; Fri, 26 Jul 2013 18:06:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2q9E-00029g-2Z for qemu-devel@nongnu.org; Fri, 26 Jul 2013 18:06:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47371 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2q9D-000295-PJ for qemu-devel@nongnu.org; Fri, 26 Jul 2013 18:06:03 -0400 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 508B6A535C for ; Sat, 27 Jul 2013 00:06:03 +0200 (CEST) From: =?UTF-8?q?Andreas=20F=C3=A4rber?= To: qemu-devel@nongnu.org Date: Sat, 27 Jul 2013 00:05:31 +0200 Message-Id: <1374876350-32189-7-git-send-email-afaerber@suse.de> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1374876350-32189-1-git-send-email-afaerber@suse.de> References: <1374876350-32189-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 195.135.220.15 Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= Subject: [Qemu-devel] [PULL 06/25] gdbstub: Drop dead code in cpu_gdb_{read, write}_register() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org GET_REG*() macros include a return statement, thus no need for break. Acked-by: Michael Walle (for lm32) Signed-off-by: Andreas Färber --- gdbstub.c | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index cd25c06..9ede3de 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1295,15 +1295,12 @@ static int cpu_gdb_read_register(CPUOpenRISCState *env, uint8_t *mem_buf, int n) switch (n) { case 32: /* PPC */ GET_REG32(env->ppc); - break; case 33: /* NPC */ GET_REG32(env->npc); - break; case 34: /* SR */ GET_REG32(env->sr); - break; default: break; @@ -1516,14 +1513,11 @@ read_register_crisv10(CPUCRISState *env, uint8_t *mem_buf, int n) switch (n) { case 16: GET_REG8(env->pregs[n - 16]); - break; case 17: GET_REG8(env->pregs[n - 16]); - break; case 20: case 21: GET_REG16(env->pregs[n - 16]); - break; default: if (n >= 23) { GET_REG32(env->pregs[n - 16]); @@ -1693,22 +1687,16 @@ static int cpu_gdb_read_register(CPUS390XState *env, uint8_t *mem_buf, int n) cc_op = calc_cc(env, env->cc_op, env->cc_src, env->cc_dst, env->cc_vr); val = deposit64(env->psw.mask, 44, 2, cc_op); GET_REGL(val); - break; case S390_PSWA_REGNUM: GET_REGL(env->psw.addr); - break; case S390_R0_REGNUM ... S390_R15_REGNUM: GET_REGL(env->regs[n-S390_R0_REGNUM]); - break; case S390_A0_REGNUM ... S390_A15_REGNUM: GET_REG32(env->aregs[n-S390_A0_REGNUM]); - break; case S390_FPC_REGNUM: GET_REG32(env->fpc); - break; case S390_F0_REGNUM ... S390_F15_REGNUM: GET_REG64(env->fregs[n-S390_F0_REGNUM].ll); - break; } return 0; @@ -1762,26 +1750,19 @@ static int cpu_gdb_read_register(CPULM32State *env, uint8_t *mem_buf, int n) switch (n) { case 32: GET_REG32(env->pc); - break; /* FIXME: put in right exception ID */ case 33: GET_REG32(0); - break; case 34: GET_REG32(env->eba); - break; case 35: GET_REG32(env->deba); - break; case 36: GET_REG32(env->ie); - break; case 37: GET_REG32(lm32_pic_get_im(env->pic_state)); - break; case 38: GET_REG32(lm32_pic_get_ip(env->pic_state)); - break; } } return 0; @@ -1844,28 +1825,22 @@ static int cpu_gdb_read_register(CPUXtensaState *env, uint8_t *mem_buf, int n) switch (reg->type) { case 9: /*pc*/ GET_REG32(env->pc); - break; case 1: /*ar*/ xtensa_sync_phys_from_window(env); GET_REG32(env->phys_regs[(reg->targno & 0xff) % env->config->nareg]); - break; case 2: /*SR*/ GET_REG32(env->sregs[reg->targno & 0xff]); - break; case 3: /*UR*/ GET_REG32(env->uregs[reg->targno & 0xff]); - break; case 4: /*f*/ GET_REG32(float32_val(env->fregs[reg->targno & 0x0f])); - break; case 8: /*a*/ GET_REG32(env->regs[reg->targno & 0x0f]); - break; default: qemu_log("%s from reg %d of unsupported type %d\n",