From patchwork Fri Jul 26 08:47:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tiejun Chen X-Patchwork-Id: 262088 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B4BFD2C00D9 for ; Fri, 26 Jul 2013 18:47:49 +1000 (EST) Received: from localhost ([::1]:47848 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2dgh-0007H1-On for incoming@patchwork.ozlabs.org; Fri, 26 Jul 2013 04:47:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2dgT-0007Gq-AM for qemu-devel@nongnu.org; Fri, 26 Jul 2013 04:47:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2dgS-0005pM-3E for qemu-devel@nongnu.org; Fri, 26 Jul 2013 04:47:33 -0400 Received: from mail1.windriver.com ([147.11.146.13]:54532) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2dgR-0005or-Ri for qemu-devel@nongnu.org; Fri, 26 Jul 2013 04:47:32 -0400 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.3) with ESMTP id r6Q8lPxW025527 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 26 Jul 2013 01:47:25 -0700 (PDT) Received: from Linux.corp.ad.wrs.com (128.224.162.214) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.342.3; Fri, 26 Jul 2013 01:47:24 -0700 From: Tiejun Chen To: Date: Fri, 26 Jul 2013 16:47:11 +0800 Message-ID: <1374828431-25517-1-git-send-email-tiejun.chen@windriver.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 147.11.146.13 Cc: mtosatti@redhat.com, avi@redhat.com Subject: [Qemu-devel] [PATCH] cpus: use cpu_is_stopped efficiently X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It makes more sense and simple later. Signed-off-by: Tiejun Chen Reviewed-by: Marcelo Tosatti --- cpus.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index c232265..a997632 100644 --- a/cpus.c +++ b/cpus.c @@ -62,6 +62,11 @@ static CPUArchState *next_cpu; +bool cpu_is_stopped(CPUState *cpu) +{ + return !runstate_is_running() || cpu->stopped; +} + static bool cpu_thread_is_idle(CPUArchState *env) { CPUState *cpu = ENV_GET_CPU(env); @@ -69,7 +74,7 @@ static bool cpu_thread_is_idle(CPUArchState *env) if (cpu->stop || cpu->queued_work_first) { return false; } - if (cpu->stopped || !runstate_is_running()) { + if (cpu_is_stopped(cpu)) { return true; } if (!cpu->halted || qemu_cpu_has_work(cpu) || @@ -432,11 +437,6 @@ void cpu_synchronize_all_post_init(void) } } -bool cpu_is_stopped(CPUState *cpu) -{ - return !runstate_is_running() || cpu->stopped; -} - static void do_vm_stop(RunState state) { if (runstate_is_running()) { @@ -455,7 +455,7 @@ static bool cpu_can_run(CPUState *cpu) if (cpu->stop) { return false; } - if (cpu->stopped || !runstate_is_running()) { + if (cpu_is_stopped(cpu)) { return false; } return true;