From patchwork Tue Jul 16 15:31:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 259442 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2243D2C0109 for ; Wed, 17 Jul 2013 01:32:35 +1000 (EST) Received: from localhost ([::1]:60145 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz7Ev-0003Ld-5K for incoming@patchwork.ozlabs.org; Tue, 16 Jul 2013 11:32:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz7Dh-0001kP-TY for qemu-devel@nongnu.org; Tue, 16 Jul 2013 11:31:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uz7Dg-0003rp-PE for qemu-devel@nongnu.org; Tue, 16 Jul 2013 11:31:17 -0400 Received: from mail-ea0-x22a.google.com ([2a00:1450:4013:c01::22a]:60286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz7Dg-0003rS-Jp for qemu-devel@nongnu.org; Tue, 16 Jul 2013 11:31:16 -0400 Received: by mail-ea0-f170.google.com with SMTP id h10so462111eaj.29 for ; Tue, 16 Jul 2013 08:31:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=ZGpjhQVqLhNGXLTv0t/LK1a4Z04b725em1G/BoX3FjE=; b=ap6dQbdIdHLadpiwEW5lDKXsBxy47DcKq3Lx6ry9sghycr1Ubv7Di6lDA2LSM1nOyR L95fLvLAK08nSg0bwgT6A27WSl+XAq30FP5+few99eTLLIf4aTTW6bg57lbWKIbRopRg JrKqEGj9yvww00RPIwKZHGL00RM8ajDgMcvMI8cQlhLGIMkxSgvF8CmIog0pdQUaepZ1 SOUVoSzxG9cyJGgHbsh7PRX05RsQqLd/bTcYKrp1UcxARbUAN35/jzW2RQNqwjUxComG 1uTqsrl3HnT0QTcmhxcBNZ9KenEqrEOjn1nTJ0TvdsoDp1pBBW0Ja9/Rc81UFCPWvHWq whvw== X-Received: by 10.14.32.197 with SMTP id o45mr2226486eea.9.1373988675770; Tue, 16 Jul 2013 08:31:15 -0700 (PDT) Received: from playground.lan (net-2-39-8-162.cust.dsl.vodafone.it. [2.39.8.162]) by mx.google.com with ESMTPSA id w43sm3550822eez.6.2013.07.16.08.31.13 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 16 Jul 2013 08:31:14 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 16 Jul 2013 17:31:02 +0200 Message-Id: <1373988662-19211-4-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1373988662-19211-1-git-send-email-pbonzini@redhat.com> References: <1373988662-19211-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::22a Cc: peter.maydell@linaro.org, stefanha@redhat.com, jan.kiszka@siemens.com Subject: [Qemu-devel] [PATCH 3/3] memory: Return -1 again on reads from unsigned regions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka This restore the behavior prior to b018ddf633 which accidentally changed the return code to 0. Specifically guests probing for register existence were affected by this. Signed-off-by: Jan Kiszka Signed-off-by: Paolo Bonzini --- memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/memory.c b/memory.c index 9938b6b..34a088e 100644 --- a/memory.c +++ b/memory.c @@ -840,7 +840,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr addr, if (current_cpu != NULL) { cpu_unassigned_access(current_cpu, addr, false, false, 0, size); } - return 0; + return -1ULL; } static void unassigned_mem_write(void *opaque, hwaddr addr,