From patchwork Fri Jun 28 18:17:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 255502 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A61582C0090 for ; Sat, 29 Jun 2013 04:24:53 +1000 (EST) Received: from localhost ([::1]:44619 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsdLn-00034R-9m for incoming@patchwork.ozlabs.org; Fri, 28 Jun 2013 14:24:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsdHQ-0004ln-M5 for qemu-devel@nongnu.org; Fri, 28 Jun 2013 14:20:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsdHO-0006Gz-Hr for qemu-devel@nongnu.org; Fri, 28 Jun 2013 14:20:20 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:54394) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsdHO-0006GT-2U; Fri, 28 Jun 2013 14:20:18 -0400 Received: from gandalf.tls.msk.ru (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 7B71742BCF; Fri, 28 Jun 2013 22:20:17 +0400 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id 8D023570; Fri, 28 Jun 2013 22:17:48 +0400 (MSK) From: Michael Tokarev To: Anthony Liguori Date: Fri, 28 Jun 2013 22:17:44 +0400 Message-Id: <1372443465-22384-14-git-send-email-mjt@msgid.tls.msk.ru> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1372443465-22384-1-git-send-email-mjt@msgid.tls.msk.ru> References: <1372443465-22384-1-git-send-email-mjt@msgid.tls.msk.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, Michael Tokarev , Gerd Hoffmann , qemu-devel@nongnu.org Subject: [Qemu-devel] [PULL 13/14] qemu-socket: don't leak opts on error X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- util/qemu-sockets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 126cbb6..095716e 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -963,7 +963,7 @@ int socket_dgram(SocketAddress *remote, SocketAddress *local, Error **errp) default: error_setg(errp, "socket type unsupported for datagram"); - return -1; + fd = -1; } qemu_opts_del(opts); return fd;