From patchwork Wed Jun 19 14:20:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Edgar E. Iglesias" X-Patchwork-Id: 252583 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1867D2C009A for ; Thu, 20 Jun 2013 00:23:58 +1000 (EST) Received: from localhost ([::1]:48824 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpJIg-0003IV-VP for incoming@patchwork.ozlabs.org; Wed, 19 Jun 2013 10:23:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpJIL-0003IL-CU for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:23:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpJIK-0004aB-Aa for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:23:33 -0400 Received: from mail-ee0-x234.google.com ([2a00:1450:4013:c00::234]:35578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpJIK-0004a0-4N for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:23:32 -0400 Received: by mail-ee0-f52.google.com with SMTP id c50so3301935eek.11 for ; Wed, 19 Jun 2013 07:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=4XuTgeYqagQN7MKA6xrAu9oh2hj85Z3UuSzEEnA2CxY=; b=Ubi4VuX+BXqFvZpJOs0c7vWbZJfq2mzIA//mS8hzmc3LvFyBX9PHKmQlw5ogo8rdXz dC10Ek5bpUPtvNL3dGYdOhBmP5iK/qZI8jDqxtzToulHgkOJ169xIcT8iozIbjKADMAs lJ5N87dmU/dnm/qpTNnqUsGI0xICQq8bQO6WoJtojaMkrlAvQPMb3pTPL6XTS5OTSS+o /uFIM0LcbkZDFpkPhUQxel6uOvAf/UTAOlJXBGwFRKWcSOuyVvvCsONeiww5YC09BVZS FAOJHaaXdl/5grzlHkh5ONL42z0VHQ8UAiACfizXOVLxWsGelf+2dHXZnW9aVbFMRr2a Giqg== X-Received: by 10.14.241.5 with SMTP id f5mr2889349eer.131.1371651810893; Wed, 19 Jun 2013 07:23:30 -0700 (PDT) Received: from localhost (h59ec325f.selukar.dyn.perspektivbredband.net. [89.236.50.95]) by mx.google.com with ESMTPSA id w43sm4916856eez.6.2013.06.19.07.23.28 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 19 Jun 2013 07:23:29 -0700 (PDT) From: edgar.iglesias@gmail.com To: qemu-devel@nongnu.org Date: Wed, 19 Jun 2013 16:20:28 +0200 Message-Id: <1371651629-31262-1-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::234 Cc: peter.crosthwaite@xilinx.com Subject: [Qemu-devel] [PATCH v2] cadence_uart: Handle backend tx errors X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Reviewed-by: Peter Crosthwaite --- v1 -> v2: Remove loop around qemu_chr_fe_write_all, it does not return short writes. hw/char/cadence_uart.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c index c2a7834..205e125 100644 --- a/hw/char/cadence_uart.c +++ b/hw/char/cadence_uart.c @@ -297,9 +297,7 @@ static void uart_write_tx_fifo(UartState *s, const uint8_t *buf, int size) return; } - while (size) { - size -= qemu_chr_fe_write(s->chr, buf, size); - } + qemu_chr_fe_write_all(s->chr, buf, size); } static void uart_receive(void *opaque, const uint8_t *buf, int size)