diff mbox

[qom-cpu,07/59] cpus: Simplify set_numa_modes()

Message ID 1370805206-26574-8-git-send-email-afaerber@suse.de
State New
Headers show

Commit Message

Andreas Färber June 9, 2013, 7:12 p.m. UTC
Use new qemu_for_each_cpu().

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 cpus.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

Comments

liguang June 10, 2013, 2:15 a.m. UTC | #1
Reviewed-by: liguang <lig.fnst@cn.fujitsu.com>

在 2013-06-09日的 21:12 +0200,Andreas Färber写道:
> Use new qemu_for_each_cpu().
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  cpus.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/cpus.c b/cpus.c
> index 1babecf..24ee974 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1188,22 +1188,22 @@ static void tcg_exec_all(void)
>      exit_request = 0;
>  }
>  
> -void set_numa_modes(void)
> +static void set_one_numa_mode(CPUState *cpu, void *data)
>  {
> -    CPUArchState *env;
> -    CPUState *cpu;
>      int i;
>  
> -    for (env = first_cpu; env != NULL; env = env->next_cpu) {
> -        cpu = ENV_GET_CPU(env);
> -        for (i = 0; i < nb_numa_nodes; i++) {
> -            if (test_bit(cpu->cpu_index, node_cpumask[i])) {
> -                cpu->numa_node = i;
> -            }
> +    for (i = 0; i < nb_numa_nodes; i++) {
> +        if (test_bit(cpu->cpu_index, node_cpumask[i])) {
> +            cpu->numa_node = i;
>          }
>      }
>  }
>  
> +void set_numa_modes(void)
> +{
> +    qemu_for_each_cpu(set_one_numa_mode, NULL);
> +}
> +
>  void list_cpus(FILE *f, fprintf_function cpu_fprintf, const char *optarg)
>  {
>      /* XXX: implement xxx_cpu_list for targets that still miss it */
diff mbox

Patch

diff --git a/cpus.c b/cpus.c
index 1babecf..24ee974 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1188,22 +1188,22 @@  static void tcg_exec_all(void)
     exit_request = 0;
 }
 
-void set_numa_modes(void)
+static void set_one_numa_mode(CPUState *cpu, void *data)
 {
-    CPUArchState *env;
-    CPUState *cpu;
     int i;
 
-    for (env = first_cpu; env != NULL; env = env->next_cpu) {
-        cpu = ENV_GET_CPU(env);
-        for (i = 0; i < nb_numa_nodes; i++) {
-            if (test_bit(cpu->cpu_index, node_cpumask[i])) {
-                cpu->numa_node = i;
-            }
+    for (i = 0; i < nb_numa_nodes; i++) {
+        if (test_bit(cpu->cpu_index, node_cpumask[i])) {
+            cpu->numa_node = i;
         }
     }
 }
 
+void set_numa_modes(void)
+{
+    qemu_for_each_cpu(set_one_numa_mode, NULL);
+}
+
 void list_cpus(FILE *f, fprintf_function cpu_fprintf, const char *optarg)
 {
     /* XXX: implement xxx_cpu_list for targets that still miss it */