diff mbox

[qom-cpu,06/59] cpus: Simplify resume_all_vcpus()

Message ID 1370805206-26574-7-git-send-email-afaerber@suse.de
State New
Headers show

Commit Message

Andreas Färber June 9, 2013, 7:12 p.m. UTC 
Use new qemu_for_each_cpu().

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 cpus.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

Comments

liguang June 10, 2013, 2:14 a.m. UTC | #1 
Reviewed-by: liguang <lig.fnst@cn.fujitsu.com>

在 2013-06-09日的 21:12 +0200，Andreas Färber写道：
> Use new qemu_for_each_cpu().
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  cpus.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/cpus.c b/cpus.c
> index ad5edfe..1babecf 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1005,16 +1005,15 @@ void cpu_resume(CPUState *cpu)
>      qemu_cpu_kick(cpu);
>  }
>  
> -void resume_all_vcpus(void)
> +static void resume_one_vcpu(CPUState *cpu, void *data)
>  {
> -    CPUArchState *penv = first_cpu;
> +    cpu_resume(cpu);
> +}
>  
> +void resume_all_vcpus(void)
> +{
>      qemu_clock_enable(vm_clock, true);
> -    while (penv) {
> -        CPUState *pcpu = ENV_GET_CPU(penv);
> -        cpu_resume(pcpu);
> -        penv = penv->next_cpu;
> -    }
> +    qemu_for_each_cpu(resume_one_vcpu, NULL);
>  }
>  
>  static void qemu_tcg_init_vcpu(CPUState *cpu)
diff mbox

Patch

diff --git a/cpus.c b/cpus.c
index ad5edfe..1babecf 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1005,16 +1005,15 @@  void cpu_resume(CPUState *cpu)
     qemu_cpu_kick(cpu);
 }
 
-void resume_all_vcpus(void)
+static void resume_one_vcpu(CPUState *cpu, void *data)
 {
-    CPUArchState *penv = first_cpu;
+    cpu_resume(cpu);
+}
 
+void resume_all_vcpus(void)
+{
     qemu_clock_enable(vm_clock, true);
-    while (penv) {
-        CPUState *pcpu = ENV_GET_CPU(penv);
-        cpu_resume(pcpu);
-        penv = penv->next_cpu;
-    }
+    qemu_for_each_cpu(resume_one_vcpu, NULL);
 }
 
 static void qemu_tcg_init_vcpu(CPUState *cpu)