From patchwork Sun Jun 9 19:13:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 250120 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3E14A2C00A2 for ; Mon, 10 Jun 2013 05:40:46 +1000 (EST) Received: from localhost ([::1]:47863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UllTo-0000SL-3q for incoming@patchwork.ozlabs.org; Sun, 09 Jun 2013 15:40:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ull4d-00012n-HP for qemu-devel@nongnu.org; Sun, 09 Jun 2013 15:14:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ull4c-0000pw-0b for qemu-devel@nongnu.org; Sun, 09 Jun 2013 15:14:43 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44462 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ull4b-0000po-PR for qemu-devel@nongnu.org; Sun, 09 Jun 2013 15:14:41 -0400 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 607D0A51FF for ; Sun, 9 Jun 2013 21:14:41 +0200 (CEST) From: =?UTF-8?q?Andreas=20F=C3=A4rber?= To: qemu-devel@nongnu.org Date: Sun, 9 Jun 2013 21:13:15 +0200 Message-Id: <1370805206-26574-49-git-send-email-afaerber@suse.de> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1370805206-26574-1-git-send-email-afaerber@suse.de> References: <1370805206-26574-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 195.135.220.15 Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= Subject: [Qemu-devel] [PATCH qom-cpu 48/59] cpus: Abstract all_cpu_threads_idle() with qemu_for_each_cpu() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Andreas Färber --- cpus.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index 7428389..506a0c8 100644 --- a/cpus.c +++ b/cpus.c @@ -77,16 +77,24 @@ static bool cpu_thread_is_idle(CPUState *cpu) return true; } -static bool all_cpu_threads_idle(void) +static void one_cpu_thread_idle(CPUState *cpu, void *data) { - CPUArchState *env; + bool *all_idle = data; - for (env = first_cpu; env != NULL; env = env->next_cpu) { - if (!cpu_thread_is_idle(ENV_GET_CPU(env))) { - return false; - } + if (!*all_idle) { + return; } - return true; + if (!cpu_thread_is_idle(cpu)) { + *all_idle = false; + } +} + +static bool all_cpu_threads_idle(void) +{ + bool ret = true; + + qemu_for_each_cpu(one_cpu_thread_idle, &ret); + return ret; } /***********************************************************/