From patchwork Wed May 29 22:08:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 247402 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 93C7F2C02A4 for ; Thu, 30 May 2013 08:09:40 +1000 (EST) Received: from localhost ([::1]:44054 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhoYs-00032U-Op for incoming@patchwork.ozlabs.org; Wed, 29 May 2013 18:09:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhoYK-0002un-6F for qemu-devel@nongnu.org; Wed, 29 May 2013 18:09:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhoYE-0004Um-Hs for qemu-devel@nongnu.org; Wed, 29 May 2013 18:09:04 -0400 Received: from vms173023pub.verizon.net ([206.46.173.23]:37477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhoYE-0004Sz-Cc for qemu-devel@nongnu.org; Wed, 29 May 2013 18:08:58 -0400 Received: from wf-rch.minyard.home ([unknown] [173.74.121.95]) by vms173023.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0MNK0051YYUBPC10@vms173023.mailsrvcs.net> for qemu-devel@nongnu.org; Wed, 29 May 2013 17:08:36 -0500 (CDT) Received: from i.minyard.home (i2.minyard.home [192.168.27.116]) by wf-rch.minyard.home (Postfix) with ESMTP id B1A831F8F8; Wed, 29 May 2013 17:08:25 -0500 (CDT) Received: by i.minyard.home (Postfix, from userid 1000) id E3AAB8045B; Wed, 29 May 2013 17:08:25 -0500 (CDT) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Wed, 29 May 2013 17:08:00 -0500 Message-id: <1369865296-19584-5-git-send-email-minyard@acm.org> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1369865296-19584-1-git-send-email-minyard@acm.org> References: <1369865296-19584-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.46.173.23 Cc: Corey Minyard , openipmi-developer@lists.sourceforge.net Subject: [Qemu-devel] [PATCH 04/20] qemu-char: remove free of chr from win_stdio_close X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Corey Minyard This will result in a double free on close, because it's freed in qemu_chr_delete() right after calling the close function. Signed-off-by: Corey Minyard --- qemu-char.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 76cddd9..1270a65 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2145,7 +2145,6 @@ static void win_stdio_close(CharDriverState *chr) } g_free(chr->opaque); - g_free(chr); } static CharDriverState *qemu_chr_open_stdio(CharDriverState *chr,