From patchwork Mon May 27 18:17:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 246635 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CF71E2C02FD for ; Tue, 28 May 2013 04:18:05 +1000 (EST) Received: from localhost ([::1]:41833 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uh1zg-0000gz-1e for incoming@patchwork.ozlabs.org; Mon, 27 May 2013 14:18:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uh1zD-0000bm-Ni for qemu-devel@nongnu.org; Mon, 27 May 2013 14:17:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uh1zB-0002hE-6z for qemu-devel@nongnu.org; Mon, 27 May 2013 14:17:35 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:54019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uh1zB-0002h3-2A for qemu-devel@nongnu.org; Mon, 27 May 2013 14:17:33 -0400 X-IronPort-AV: E=Sophos;i="4.87,752,1363132800"; d="scan'208";a="26301684" Received: from accessns.citrite.net (HELO FTLPEX01CL03.citrite.net) ([10.9.154.239]) by FTLPIPO02.CITRIX.COM with ESMTP/TLS/AES128-SHA; 27 May 2013 18:17:32 +0000 Received: from ukmail1.uk.xensource.com (10.80.16.128) by smtprelay.citrix.com (10.13.107.80) with Microsoft SMTP Server id 14.2.342.3; Mon, 27 May 2013 14:17:32 -0400 Received: from kaball.uk.xensource.com ([10.80.2.59]) by ukmail1.uk.xensource.com with esmtp (Exim 4.69) (envelope-from ) id 1Uh1z4-00083e-Oc; Mon, 27 May 2013 19:17:26 +0100 From: Stefano Stabellini To: Date: Mon, 27 May 2013 19:17:10 +0100 Message-ID: <1369678631-821-1-git-send-email-stefano.stabellini@eu.citrix.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.63 Cc: anthony.perard@citrix.com, pbonzini@redhat.com, aliguori@us.ibm.com, xen-devel@lists.xensource.com, Stefano Stabellini Subject: [Qemu-devel] [PATCH 1/2] xen: remove xen_vcpu_init X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org No need for xen_vcpu_init anymore: - the RTC emulator doesn't have any periodic timers continuously running even in absence of guest interactions anymore; - qemu_dummy_start_vcpu takes care of disabling TCG for us, so we don't need to do it manually here. Signed-off-by: Stefano Stabellini Reviewed-by: Andreas Färber --- hw/i386/pc_piix.c | 1 - xen-all.c | 23 ----------------------- 2 files changed, 0 insertions(+), 24 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 43ab480..1ef4cbf 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -324,7 +324,6 @@ static void pc_xen_hvm_init(QEMUMachineInitArgs *args) hw_error("xen hardware virtual machine initialisation failed"); } pc_init_pci_no_kvmclock(args); - xen_vcpu_init(); } #endif diff --git a/xen-all.c b/xen-all.c index 539a154..bc308f4 100644 --- a/xen-all.c +++ b/xen-all.c @@ -574,29 +574,6 @@ void qmp_xen_set_global_dirty_log(bool enable, Error **errp) } } -/* VCPU Operations, MMIO, IO ring ... */ - -static void xen_reset_vcpu(void *opaque) -{ - CPUState *cpu = opaque; - - cpu->halted = 1; -} - -void xen_vcpu_init(void) -{ - if (first_cpu != NULL) { - CPUState *cpu = ENV_GET_CPU(first_cpu); - - qemu_register_reset(xen_reset_vcpu, cpu); - xen_reset_vcpu(cpu); - } - /* if rtc_clock is left to default (host_clock), disable it */ - if (rtc_clock == host_clock) { - qemu_clock_enable(rtc_clock, false); - } -} - /* get the ioreq packets from share mem */ static ioreq_t *cpu_get_ioreq_from_shared_memory(XenIOState *state, int vcpu) {