From patchwork Fri May 24 17:02:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 246270 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4001D2C016F for ; Sat, 25 May 2013 03:40:20 +1000 (EST) Received: from localhost ([::1]:35343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfvUG-0001rK-IQ for incoming@patchwork.ozlabs.org; Fri, 24 May 2013 13:09:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfvOx-0001uq-Fo for qemu-devel@nongnu.org; Fri, 24 May 2013 13:03:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfvOs-00014G-Kk for qemu-devel@nongnu.org; Fri, 24 May 2013 13:03:35 -0400 Received: from mail-ea0-x229.google.com ([2a00:1450:4013:c01::229]:48358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfvOs-000143-Er for qemu-devel@nongnu.org; Fri, 24 May 2013 13:03:30 -0400 Received: by mail-ea0-f169.google.com with SMTP id m14so2604506eaj.14 for ; Fri, 24 May 2013 10:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=U+4uXXzJUzIBnlI3Xv1FjlCGd5f4tbFvvTxXb2qXrsE=; b=tyOCZP2H0wryid/X+vaiqDLxmZLG/ovLmUJluCK8Hh649uTghtJ9EWGtMIStKssIaK 0uzRGHQlNc0QU0ybEQPPN4YCg9uFH1VWQBiJ1m2CHkizdZ7oQSgMHDTIAXQQyxDDcO4h 1H9EtgcocsSPrJ7BRHB9DEM5J+nGhHpfKnpSdSaiDravriFDn9yi5GTLwDWqSg2t1KLR 6PRdA12YVGG0pooEVWNwCDCajDDA9+zUO/0bI0u2VQ/cdx25ZhLF3P0ZSAYMqnvsIFZT at5hcnFyZ+1zlNSJa+M4kxOToiIHmVQdcV12Cmjr8UaG2+q3VZXIpLbLNIA4PNk7Ej5i sFPw== X-Received: by 10.15.31.201 with SMTP id y49mr563443eeu.149.1369415009625; Fri, 24 May 2013 10:03:29 -0700 (PDT) Received: from playground.lan (net-37-117-138-128.cust.dsl.vodafone.it. [37.117.138.128]) by mx.google.com with ESMTPSA id z52sm24872219eea.1.2013.05.24.10.03.26 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 24 May 2013 10:03:27 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 24 May 2013 19:02:59 +0200 Message-Id: <1369414987-8839-8-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1369414987-8839-1-git-send-email-pbonzini@redhat.com> References: <1369414987-8839-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::229 Cc: Jan Kiszka Subject: [Qemu-devel] [PATCH 07/15] memory: Replace open-coded memory_region_is_romd X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka Improves readability. Reviewed-by: Peter Maydell Signed-off-by: Jan Kiszka --- translate-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/translate-all.c b/translate-all.c index da93608..0d84b0d 100644 --- a/translate-all.c +++ b/translate-all.c @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr) section = phys_page_find(address_space_memory.dispatch, addr >> TARGET_PAGE_BITS); if (!(memory_region_is_ram(section->mr) - || (section->mr->rom_device && section->mr->readable))) { + || memory_region_is_romd(section->mr))) { return; } ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK)