From patchwork Thu May 23 03:38:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fam Zheng X-Patchwork-Id: 245817 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9813B2C00AC for ; Thu, 23 May 2013 13:42:31 +1000 (EST) Received: from localhost ([::1]:58120 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfMQ9-0003UO-Q8 for incoming@patchwork.ozlabs.org; Wed, 22 May 2013 23:42:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfMN2-0006eb-6G for qemu-devel@nongnu.org; Wed, 22 May 2013 23:39:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfMMv-0004I8-Me for qemu-devel@nongnu.org; Wed, 22 May 2013 23:39:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfMMv-0004I0-Ex for qemu-devel@nongnu.org; Wed, 22 May 2013 23:39:09 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4N3d8DM021937 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 22 May 2013 23:39:08 -0400 Received: from localhost.nay.redhat.com ([10.66.7.14]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4N3cFSR024477; Wed, 22 May 2013 23:39:04 -0400 From: Fam Zheng To: qemu-devel@nongnu.org Date: Thu, 23 May 2013 11:38:07 +0800 Message-Id: <1369280289-20928-10-git-send-email-famz@redhat.com> In-Reply-To: <1369280289-20928-1-git-send-email-famz@redhat.com> References: <1369280289-20928-1-git-send-email-famz@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: kwolf@redhat.com, jcody@redhat.com, Fam Zheng , stefanha@redhat.com Subject: [Qemu-devel] [PATCH v5 09/11] curl: add cache quota. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Introduce a cache quota: BDRVCURLState.cache_quota. When adding new CURLDataCache to BDRVCURLState, if number of existing CURLDataCache is larger than CURL_CACHE_QUOTA, try to release some first to limit the in memory cache size. A least used entry is selected for releasing. Signed-off-by: Fam Zheng --- block/curl.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/block/curl.c b/block/curl.c index 3ea2552..5adbc84 100644 --- a/block/curl.c +++ b/block/curl.c @@ -40,6 +40,7 @@ #define SECTOR_SIZE 512 #define READ_AHEAD_SIZE (256 * 1024) +#define CURL_CACHE_QUOTA 10 struct BDRVCURLState; @@ -90,6 +91,8 @@ typedef struct BDRVCURLState { QEMUTimer *timer; /* List of data cache ordered by access, freed from tail */ QLIST_HEAD(, CURLDataCache) cache; + /* Threshold to release unused cache when cache list is longer than it */ + int cache_quota; /* Whether http server accept range in header */ bool accept_range; } BDRVCURLState; @@ -526,6 +529,8 @@ static int curl_open(BlockDriverState *bs, QDict *options, int flags) curl_multi_socket_action(s->multi, CURL_SOCKET_TIMEOUT, 0, &running); qemu_opts_del(opts); + s->cache_quota = CURL_CACHE_QUOTA; + return 0; out: @@ -595,6 +600,27 @@ static void curl_readv_bh_cb(void *p) cache->data_len = aio_bytes + s->readahead_size; cache->write_pos = 0; cache->data = g_malloc(cache->data_len); + /* Try to release some cache */ + while (0 && s->cache_quota <= 0) { + CURLDataCache *p; + CURLDataCache *q = NULL; + assert(!QLIST_EMPTY(&s->cache)); + for (p = QLIST_FIRST(&s->cache); + p; p = QLIST_NEXT(p, next)) { + if (p->use_count == 0) { + q = p; + } + } + if (!q) { + break; + } + QLIST_REMOVE(q, next); + g_free(q->data); + q->data = NULL; + g_free(q); + q = NULL; + s->cache_quota++; + } QLIST_INSERT_HEAD(&s->acbs, acb, next); snprintf(state->range, sizeof(state->range) - 1, "%zd-%zd", cache->base_pos, @@ -605,6 +631,7 @@ static void curl_readv_bh_cb(void *p) QLIST_INSERT_HEAD(&s->cache, cache, next); state->cache = cache; cache->use_count++; + s->cache_quota--; curl_multi_add_handle(s->multi, state->curl); /* kick off curl to start the action */ curl_multi_socket_action(s->multi, 0, CURL_SOCKET_TIMEOUT, &running);