From patchwork Mon May 13 15:08:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 243422 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4CE1D2C0092 for ; Tue, 14 May 2013 01:12:20 +1000 (EST) Received: from localhost ([::1]:34451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbuQE-0001DS-EW for incoming@patchwork.ozlabs.org; Mon, 13 May 2013 11:12:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbuOf-0007wY-MZ for qemu-devel@nongnu.org; Mon, 13 May 2013 11:10:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UbuOe-0004jq-8M for qemu-devel@nongnu.org; Mon, 13 May 2013 11:10:41 -0400 Received: from mail-ie0-x22d.google.com ([2607:f8b0:4001:c03::22d]:33925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbuOe-0004jl-3E for qemu-devel@nongnu.org; Mon, 13 May 2013 11:10:40 -0400 Received: by mail-ie0-f173.google.com with SMTP id k5so12557701iea.32 for ; Mon, 13 May 2013 08:10:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=+YxCr7ieAkPD+q7TxF6zdql7en6WJ3d1S0zqOmXLeew=; b=bYuq1tK0EfdxFAyvKfNF/NsXPxpS9KJypFI6nkbaIReZ+9vOnMlePHKndZLYHr5ku0 /hWX+TLi0KHpa3cdqoD9STViEZ+aJ3U5mI9dBqfThy6RKtQeTHhdtmuIRNvo4jzgF0Vy vODLvGJzwR4iLIKsfTm3RPTYrXElZDDXLmQ7rDLq2ayYTyjspK4kUNeGa7bvvPHia2oc AGiGQbD1joZ6nu4U+bi0gCsQZgV05IY3TapFBbTlowv20dnOO/RwTAS1smOyCVZZSzaK NvL18l7qr4O9Ll6oFxuppilUrJjxhq5KZYBZFA4j1bA7shfhb6Q4qnuEov0EfWJSnsbH kCzQ== X-Received: by 10.50.134.100 with SMTP id pj4mr10597998igb.73.1368457839666; Mon, 13 May 2013 08:10:39 -0700 (PDT) Received: from localhost ([32.97.110.51]) by mx.google.com with ESMTPSA id qs4sm18886929igb.10.2013.05.13.08.10.37 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 13 May 2013 08:10:38 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 13 May 2013 10:08:23 -0500 Message-Id: <1368457703-30663-3-git-send-email-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1368457703-30663-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1368457703-30663-1-git-send-email-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c03::22d Cc: aliguori@us.ibm.com, lersek@redhat.com Subject: [Qemu-devel] [PATCH 2/2] qga: unlink just created guest-file if fchmod() or fdopen() fails on it X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Laszlo Ersek We shouldn't allow guest filesystem pollution on error paths. Suggested-by: Eric Blake Signed-off-by: Laszlo Ersek Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino Signed-off-by: Michael Roth --- qga/commands-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 2eec712..e199738 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -355,6 +355,9 @@ safe_open_or_create(const char *path, const char *mode, Error **err) } close(fd); + if (oflag & O_CREAT) { + unlink(path); + } } }