Message ID | 1367250772-17928-1-git-send-email-jlarrew@linux.vnet.ibm.com |
---|---|
State | New |
Headers | show |
Jesse Larrew <jlarrew@linux.vnet.ibm.com> writes: > libqtest.c can segfault when calling fclose() if the pidfile wasn't > opened successfully. This patch fixes the issue. > > Signed-off-by: Jesse Larrew <jlarrew@linux.vnet.ibm.com> Reviewed-by: Anthony Liguori <aliguori@us.ibm.com> Regards, Anthony Liguori > --- > tests/libqtest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/libqtest.c b/tests/libqtest.c > index 884f959..879ffe9 100644 > --- a/tests/libqtest.c > +++ b/tests/libqtest.c > @@ -99,8 +99,8 @@ static pid_t qtest_qemu_pid(QTestState *s) > if (fgets(buffer, sizeof(buffer), f)) { > pid = atoi(buffer); > } > + fclose(f); > } > - fclose(f); > return pid; > } > > -- > 1.7.11.7
Applied. Thanks. Regards, Anthony Liguori
diff --git a/tests/libqtest.c b/tests/libqtest.c index 884f959..879ffe9 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -99,8 +99,8 @@ static pid_t qtest_qemu_pid(QTestState *s) if (fgets(buffer, sizeof(buffer), f)) { pid = atoi(buffer); } + fclose(f); } - fclose(f); return pid; }
libqtest.c can segfault when calling fclose() if the pidfile wasn't opened successfully. This patch fixes the issue. Signed-off-by: Jesse Larrew <jlarrew@linux.vnet.ibm.com> --- tests/libqtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)