From patchwork Fri Apr 26 17:51:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 239895 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 07EC32C00CD for ; Sat, 27 Apr 2013 03:52:14 +1000 (EST) Received: from localhost ([::1]:58480 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVmoe-0007Cj-Ay for incoming@patchwork.ozlabs.org; Fri, 26 Apr 2013 13:52:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVmoP-0007CX-AO for qemu-devel@nongnu.org; Fri, 26 Apr 2013 13:51:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVmoO-0003Od-G3 for qemu-devel@nongnu.org; Fri, 26 Apr 2013 13:51:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVmoO-0003OR-8B for qemu-devel@nongnu.org; Fri, 26 Apr 2013 13:51:56 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3QHps9R016681 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 26 Apr 2013 13:51:55 -0400 Received: from thinkpad.redhat.com (vpn-239-182.phx2.redhat.com [10.3.239.182]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3QHpqYg017876; Fri, 26 Apr 2013 13:51:53 -0400 From: Igor Mammedov To: qemu-devel@nongnu.org Date: Fri, 26 Apr 2013 19:51:52 +0200 Message-Id: <1366998712-24442-1-git-send-email-imammedo@redhat.com> In-Reply-To: <517ABBB5.5070404@suse.de> References: <517ABBB5.5070404@suse.de> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: aliguori@us.ibm.com, afaerber@suse.de, ehabkost@redhat.com Subject: [Qemu-devel] [PATCH] target-i386: Do not allow to set apic-id once CPU is realized X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f1cecc0..0d9493d 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1284,11 +1284,18 @@ static void x86_cpuid_set_apic_id(Object *obj, Visitor *v, void *opaque, const char *name, Error **errp) { X86CPU *cpu = X86_CPU(obj); + DeviceState *dev = DEVICE(obj); const int64_t min = 0; const int64_t max = UINT32_MAX; Error *error = NULL; int64_t value; + if (dev->realized) { + error_setg(errp, "Attempt to set property '%s' on '%s' after " + "it was realized", name, object_get_typename(obj)); + return; + } + visit_type_int(v, &value, name, &error); if (error) { error_propagate(errp, error);