From patchwork Sat Mar 30 23:54:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Jarno X-Patchwork-Id: 232582 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9FE5E2C00EA for ; Sun, 31 Mar 2013 10:55:21 +1100 (EST) Received: from localhost ([::1]:39649 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UM5cF-0002vU-IA for incoming@patchwork.ozlabs.org; Sat, 30 Mar 2013 19:55:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UM5bz-0002uG-MK for qemu-devel@nongnu.org; Sat, 30 Mar 2013 19:55:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UM5by-00029o-9m for qemu-devel@nongnu.org; Sat, 30 Mar 2013 19:55:03 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:44584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UM5by-00024n-2w for qemu-devel@nongnu.org; Sat, 30 Mar 2013 19:55:02 -0400 Received: from [2001:470:d4ed:0:ea11:32ff:fea1:831a] (helo=ohm.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1UM5bv-0004V7-Jm; Sun, 31 Mar 2013 00:54:59 +0100 Received: from aurel32 by ohm.aurel32.net with local (Exim 4.80) (envelope-from ) id 1UM5bu-0001Zf-DJ; Sun, 31 Mar 2013 00:54:58 +0100 From: Aurelien Jarno To: qemu-devel@nongnu.org Date: Sun, 31 Mar 2013 00:54:46 +0100 Message-Id: <1364687686-6006-1-git-send-email-aurelien@aurel32.net> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:470:1f15:c4f::1 Cc: Alexander Graf , Aurelien Jarno , Richard Henderson Subject: [Qemu-devel] [PATCH] target-ppc: fix nego and subf*o instructions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The overflow computation of nego and subf*o instructions has been broken in commit ffe30937. This patch fixes it. With this change the PPC emulation passes the Gwenole Beauchesne testsuite again. Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- target-ppc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 5e741d1..062493a 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -749,7 +749,7 @@ static inline void gen_op_arith_compute_ov(DisasContext *ctx, TCGv arg0, tcg_gen_xor_tl(cpu_ov, arg0, arg1); tcg_gen_xor_tl(t0, arg1, arg2); if (sub) { - tcg_gen_and_tl(cpu_ov, cpu_ov, t0); + tcg_gen_andc_tl(cpu_ov, t0, cpu_ov); } else { tcg_gen_andc_tl(cpu_ov, cpu_ov, t0); }