From patchwork Tue Mar 19 19:44:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mitsyanko X-Patchwork-Id: 229214 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2535E2C009D for ; Wed, 20 Mar 2013 06:45:44 +1100 (EST) Received: from localhost ([::1]:38979 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI2Te-0005I8-DT for incoming@patchwork.ozlabs.org; Tue, 19 Mar 2013 15:45:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI2TC-00058G-SB for qemu-devel@nongnu.org; Tue, 19 Mar 2013 15:45:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UI2T7-00044P-E9 for qemu-devel@nongnu.org; Tue, 19 Mar 2013 15:45:14 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:44926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI2T7-00041v-82 for qemu-devel@nongnu.org; Tue, 19 Mar 2013 15:45:09 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJX002D4AV6F590@mailout4.w1.samsung.com> for qemu-devel@nongnu.org; Tue, 19 Mar 2013 19:45:07 +0000 (GMT) X-AuditID: cbfec7f5-b7fd76d000007247-8e-5148c043e7e8 Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 19.9D.29255.340C8415; Tue, 19 Mar 2013 19:45:07 +0000 (GMT) Received: from mitsyankoPC.rnd.samsung.ru ([106.109.129.86]) by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MJX008ZMAUWFTA0@eusync2.samsung.com> for qemu-devel@nongnu.org; Tue, 19 Mar 2013 19:45:07 +0000 (GMT) From: Igor Mitsyanko To: qemu-devel@nongnu.org Date: Tue, 19 Mar 2013 23:44:56 +0400 Message-id: <1363722296-29940-3-git-send-email-i.mitsyanko@gmail.com> X-Mailer: git-send-email 1.7.5.4 In-reply-to: <1363722296-29940-1-git-send-email-i.mitsyanko@gmail.com> References: <1363722296-29940-1-git-send-email-i.mitsyanko@gmail.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKJMWRmVeSWpSXmKPExsVy+t/xK7rOBzwCDQ508lsc793B4sDo8eTa ZqYAxigum5TUnMyy1CJ9uwSujDlb+lkLWjgqXk7qYmtg3MXWxcjJISFgIvFu+xMoW0ziwr31 QDYXh5DAUkaJKUsfQjmrmST2/97KAlLFJqAjseP2FFYQW0RAUuJ312lmEJtZIFbi1tL5YLYw kH3p11mwqSwCqhLzt30Eq+cVcJXY9fM8E8Q2BYlfR1aBxTkF3CS6/veDxYWAarpn7mKZwMi7 gJFhFaNoamlyQXFSeq6RXnFibnFpXrpecn7uJkaI17/uYFx6zOoQowAHoxIP78vZHoFCrIll xZW5hxglOJiVRHh9dwCFeFMSK6tSi/Lji0pzUosPMTJxcEo1MJ6a8OxZzkqv1W9OikYo8pe4 6B3/waspOisgSthLxG5JS+Wdh+rsH+8e2JXG32am8nz5i8cnC7x5KsKszj4qvVNoUx/P/2Wq 3h+fjtIDgby/jaIlX80ukVKOel4n4ty4YJFvSp1jxrLj53nP/Z/YdvH/uwfVxzPK3NyPqE3k ql+549SFx5Xyy5RYijMSDbWYi4oTARtdWMLYAQAA X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 210.118.77.14 Cc: peter.maydell@linaro.org, kraxel@redhat.com, i.mitsyanko@samsung.com Subject: [Qemu-devel] [PATCH 2/2] hw/vmware_vga.c: fix screen resize bug introduced after console revamp X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org In vmsvga display update function, a pointer to DisplaySurface must be acquired after a call to vmsvga_check_size since this function might replace current DisplaySurface with a new one. Signed-off-by: Igor Mitsyanko --- hw/vmware_vga.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index 5b9ce8f..c0aac31 100644 --- a/hw/vmware_vga.c +++ b/hw/vmware_vga.c @@ -995,7 +995,7 @@ static inline void vmsvga_check_size(struct vmsvga_state_s *s) static void vmsvga_update_display(void *opaque) { struct vmsvga_state_s *s = opaque; - DisplaySurface *surface = qemu_console_surface(s->vga.con); + DisplaySurface *surface; bool dirty = false; if (!s->enable) { @@ -1004,6 +1004,7 @@ static void vmsvga_update_display(void *opaque) } vmsvga_check_size(s); + surface = qemu_console_surface(s->vga.con); vmsvga_fifo_run(s); vmsvga_update_rect_flush(s);