diff mbox

[RFC,03/14] qdev: remove redundant abort()

Message ID 1363161681-13878-4-git-send-email-lig.fnst@cn.fujitsu.com
State New
Headers show

Commit Message

liguang March 13, 2013, 8:01 a.m. UTC 
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
 hw/qdev.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

Comments

Andreas Färber March 18, 2013, 8:26 a.m. UTC | #1 
Am 13.03.2013 09:01, schrieb liguang:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
>  hw/qdev.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/qdev.c b/hw/qdev.c
> index 689cd54..2bed9d8 100644
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -116,11 +116,10 @@ DeviceState *qdev_create(BusState *bus, const char *name)
>          if (bus) {
>              error_report("Unknown device '%s' for bus '%s'", name,
>                           object_get_typename(OBJECT(bus)));
> -            abort();
>          } else {
>              error_report("Unknown device '%s' for default sysbus", name);
> -            abort();
>          }
> +        abort();
>      }
>  
>      return dev;

Reviewed-by: Andreas Färber <afaerber@suse.de>

However this being a fatal abort, it doesn't really matter too much.

Andreas
liguang March 21, 2013, 6:24 a.m. UTC | #2 
ping ...
can this change be accepted?

在 2013-03-18一的 09:26 +0100，Andreas Färber写道：
> Am 13.03.2013 09:01, schrieb liguang:
> > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> > ---
> >  hw/qdev.c |    3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> > 
> > diff --git a/hw/qdev.c b/hw/qdev.c
> > index 689cd54..2bed9d8 100644
> > --- a/hw/qdev.c
> > +++ b/hw/qdev.c
> > @@ -116,11 +116,10 @@ DeviceState *qdev_create(BusState *bus, const char *name)
> >          if (bus) {
> >              error_report("Unknown device '%s' for bus '%s'", name,
> >                           object_get_typename(OBJECT(bus)));
> > -            abort();
> >          } else {
> >              error_report("Unknown device '%s' for default sysbus", name);
> > -            abort();
> >          }
> > +        abort();
> >      }
> >  
> >      return dev;
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> However this being a fatal abort, it doesn't really matter too much.
> 
> Andreas
>
diff mbox

Patch

diff --git a/hw/qdev.c b/hw/qdev.c
index 689cd54..2bed9d8 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -116,11 +116,10 @@  DeviceState *qdev_create(BusState *bus, const char *name)
         if (bus) {
             error_report("Unknown device '%s' for bus '%s'", name,
                          object_get_typename(OBJECT(bus)));
-            abort();
         } else {
             error_report("Unknown device '%s' for default sysbus", name);
-            abort();
         }
+        abort();
     }
 
     return dev;