diff mbox

[15/19,fixup] vc

Message ID 1363078589-15233-16-git-send-email-kraxel@redhat.com
State New
Headers show

Commit Message

Gerd Hoffmann March 12, 2013, 8:56 a.m. UTC 
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 qemu-char.c |    3 +++
 1 file changed, 3 insertions(+)

Comments

Eric Blake March 12, 2013, 5:42 p.m. UTC | #1 
On 03/12/2013 02:56 AM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qemu-char.c |    3 +++
>  1 file changed, 3 insertions(+)

Did something go wrong in your rebase?  The subject line suggest you
intended to squash this to another patch.

> 
> diff --git a/qemu-char.c b/qemu-char.c
> index ef10200..a1c668f 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -3713,6 +3713,9 @@ ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend,
>          chr = qemu_chr_open_spice_port(backend->spiceport->fqdn);
>          break;
>  #endif
> +    case CHARDEV_BACKEND_KIND_VC:
> +        chr = vc_init(backend->vc);
> +        break;
>      default:
>          error_setg(errp, "unknown chardev backend (%d)", backend->kind);
>          break;
>
Gerd Hoffmann March 13, 2013, 6:46 a.m. UTC | #2 
On 03/12/13 18:42, Eric Blake wrote:
> On 03/12/2013 02:56 AM, Gerd Hoffmann wrote:
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- qemu-char.c
>> |    3 +++ 1 file changed, 3 insertions(+)
> 
> Did something go wrong in your rebase?  The subject line suggest
> you intended to squash this to another patch.

Yes, into #14 (see my cover letter reply).

cheers,
  Gerd
diff mbox

Patch

diff --git a/qemu-char.c b/qemu-char.c
index ef10200..a1c668f 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -3713,6 +3713,9 @@  ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend,
         chr = qemu_chr_open_spice_port(backend->spiceport->fqdn);
         break;
 #endif
+    case CHARDEV_BACKEND_KIND_VC:
+        chr = vc_init(backend->vc);
+        break;
     default:
         error_setg(errp, "unknown chardev backend (%d)", backend->kind);
         break;