diff mbox

[for-next,v3,1/5] tmp105-test: Combine assertions of 16-bit responses

Message ID 1360609282-22051-2-git-send-email-afaerber@suse.de
State New
Headers show

Commit Message

Andreas Färber Feb. 11, 2013, 7:01 p.m. UTC 
From: Andreas Färber <andreas.faerber@web.de>

Instead of comparing bytes individually, compare the full values.
This aids spotting endianness issues.

Signed-off-by: Andreas Färber <andreas.faerber@web.de>
---
 tests/tmp105-test.c |    8 ++++----
 1 Datei geändert, 4 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-)
diff mbox

Patch

diff --git a/tests/tmp105-test.c b/tests/tmp105-test.c
index a6ad213..a1fe99e 100644
--- a/tests/tmp105-test.c
+++ b/tests/tmp105-test.c
@@ -40,16 +40,16 @@  static void send_and_receive(void)
     cmd[2] = 0x34;
     i2c_send(i2c, addr, cmd, 3);
     i2c_recv(i2c, addr, resp, 2);
-    g_assert_cmphex(resp[0], ==, cmd[1]);
-    g_assert_cmphex(resp[1], ==, cmd[2]);
+    g_assert_cmphex(((uint16_t)resp[0] << 8) | resp[1], ==,
+                    ((uint16_t)cmd[1] << 8) | cmd[2]);
 
     cmd[0] = TMP105_REG_T_HIGH;
     cmd[1] = 0x42;
     cmd[2] = 0x31;
     i2c_send(i2c, addr, cmd, 3);
     i2c_recv(i2c, addr, resp, 2);
-    g_assert_cmphex(resp[0], ==, cmd[1]);
-    g_assert_cmphex(resp[1], ==, cmd[2]);
+    g_assert_cmphex(((uint16_t)resp[0] << 8) | resp[1], ==,
+                    ((uint16_t)cmd[1] << 8) | cmd[2]);
 }
 
 int main(int argc, char **argv)