mbox

[00/14] migration queue

Message ID 1358248702-14278-1-git-send-email-quintela@redhat.com
State New
Headers show

Pull-request

git://repo.or.cz/qemu/quintela.git thread.next

Message

Juan Quintela Jan. 15, 2013, 11:18 a.m. UTC
Hi

This is the intersect of the paolo & me patches for migration thread,
please consided for inclusion.

The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a05031988c:

  virtio-9p: fix compilation error. (2013-01-14 18:52:39 -0600)

are available in the git repository at:

  git://repo.or.cz/qemu/quintela.git thread.next

for you to fetch changes up to 869342e49d89763f7590ebc52eaecd9ce9f7baa1:

  Rename buffered_ to migration_ (2013-01-15 12:14:40 +0100)

----------------------------------------------------------------
Juan Quintela (8):
      qemu-file: Only set last_error if it is not already set
      migration: move begining stage to the migration thread
      migration: Add buffered_flush error handling
      migration: move exit condition to migration thread
      migration: unfold rest of migrate_fd_put_ready() into thread
      migration: Only go to the iterate stage if there is anything to send
      migration: remove argument to qemu_savevm_state_cancel
      Rename buffered_ to migration_

Paolo Bonzini (6):
      Unlock ramlist lock also in error case
      Protect migration_bitmap_sync() with the ramlist lock
      use XFER_LIMIT_RATIO consistently
      migration: make function static
      migration: remove double call to migrate_fd_close
      migration: fix off-by-one in buffered_rate_limit

 arch_init.c                   |   6 +-
 include/migration/migration.h |   3 -
 include/sysemu/sysemu.h       |   2 +-
 migration.c                   | 183 ++++++++++++++++++++----------------------
 savevm.c                      |  12 +--
 5 files changed, 98 insertions(+), 108 deletions(-)

Comments

Eric Blake Jan. 15, 2013, 7:50 p.m. UTC | #1
On 01/15/2013 04:18 AM, Juan Quintela wrote:
> Hi
> 
> This is the intersect of the paolo & me patches for migration thread,
> please consided for inclusion.
> 

> 
>  arch_init.c                   |   6 +-
>  include/migration/migration.h |   3 -
>  include/sysemu/sysemu.h       |   2 +-
>  migration.c                   | 183 ++++++++++++++++++++----------------------
>  savevm.c                      |  12 +--
>  5 files changed, 98 insertions(+), 108 deletions(-)

I found some commit message improvements in 3 and 8, but as that does
not affect the code...

Series: Reviewed-by: Eric Blake <eblake@redhat.com>
Anthony Liguori Jan. 16, 2013, 6:14 p.m. UTC | #2
Juan Quintela <quintela@redhat.com> writes:

> Hi
>
> This is the intersect of the paolo & me patches for migration thread,
> please consided for inclusion.
>
> The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a05031988c:
>
>   virtio-9p: fix compilation error. (2013-01-14 18:52:39 -0600)
>
> are available in the git repository at:
>
>   git://repo.or.cz/qemu/quintela.git thread.next
>
> for you to fetch changes up to 869342e49d89763f7590ebc52eaecd9ce9f7baa1:
>
>   Rename buffered_ to migration_ (2013-01-15 12:14:40 +0100)

If this a PULL request, you should put 'PULL' in the subject.

Regards,

Anthony Liguori

>
> ----------------------------------------------------------------
> Juan Quintela (8):
>       qemu-file: Only set last_error if it is not already set
>       migration: move begining stage to the migration thread
>       migration: Add buffered_flush error handling
>       migration: move exit condition to migration thread
>       migration: unfold rest of migrate_fd_put_ready() into thread
>       migration: Only go to the iterate stage if there is anything to send
>       migration: remove argument to qemu_savevm_state_cancel
>       Rename buffered_ to migration_
>
> Paolo Bonzini (6):
>       Unlock ramlist lock also in error case
>       Protect migration_bitmap_sync() with the ramlist lock
>       use XFER_LIMIT_RATIO consistently
>       migration: make function static
>       migration: remove double call to migrate_fd_close
>       migration: fix off-by-one in buffered_rate_limit
>
>  arch_init.c                   |   6 +-
>  include/migration/migration.h |   3 -
>  include/sysemu/sysemu.h       |   2 +-
>  migration.c                   | 183 ++++++++++++++++++++----------------------
>  savevm.c                      |  12 +--
>  5 files changed, 98 insertions(+), 108 deletions(-)
Paolo Bonzini Jan. 17, 2013, 10:50 a.m. UTC | #3
Il 16/01/2013 19:14, Anthony Liguori ha scritto:
> Juan Quintela <quintela@redhat.com> writes:
> 
>> Hi
>>
>> This is the intersect of the paolo & me patches for migration thread,
>> please consided for inclusion.
>>
>> The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a05031988c:
>>
>>   virtio-9p: fix compilation error. (2013-01-14 18:52:39 -0600)
>>
>> are available in the git repository at:
>>
>>   git://repo.or.cz/qemu/quintela.git thread.next
>>
>> for you to fetch changes up to 869342e49d89763f7590ebc52eaecd9ce9f7baa1:
>>
>>   Rename buffered_ to migration_ (2013-01-15 12:14:40 +0100)
> 
> If this a PULL request, you should put 'PULL' in the subject.

It shouldn't be, because the patches have never been posted before.
That said, I'm okay with pulling all patches except the last one.

Paolo
Juan Quintela Jan. 17, 2013, 12:46 p.m. UTC | #4
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 16/01/2013 19:14, Anthony Liguori ha scritto:
>> Juan Quintela <quintela@redhat.com> writes:
>> 
>>> Hi
>>>
>>> This is the intersect of the paolo & me patches for migration thread,
>>> please consided for inclusion.
>>>
>>> The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a05031988c:
>>>
>>>   virtio-9p: fix compilation error. (2013-01-14 18:52:39 -0600)
>>>
>>> are available in the git repository at:
>>>
>>>   git://repo.or.cz/qemu/quintela.git thread.next
>>>
>>> for you to fetch changes up to 869342e49d89763f7590ebc52eaecd9ce9f7baa1:
>>>
>>>   Rename buffered_ to migration_ (2013-01-15 12:14:40 +0100)
>> 
>> If this a PULL request, you should put 'PULL' in the subject.
>
> It shouldn't be, because the patches have never been posted before.
> That said, I'm okay with pulling all patches except the last one.

I will add that as reviewed by? O:-)

Sending all less the last one with proper PULL request.

Later, Juan.
Paolo Bonzini Jan. 17, 2013, 1 p.m. UTC | #5
Il 17/01/2013 13:46, Juan Quintela ha scritto:
>> >
>> > It shouldn't be, because the patches have never been posted before.
>> > That said, I'm okay with pulling all patches except the last one.
> I will add that as reviewed by? O:-)

Yes.

Paolo